[dpdk-dev] [PATCH 07/27] sched: update pipe profile add api

Stephen Hemminger stephen at networkplumber.org
Tue May 28 16:06:58 CEST 2019


On Tue, 28 May 2019 14:05:33 +0200
Lukasz Krakowiak <lukaszx.krakowiak at intel.com> wrote:

>  
>  static int
>  pipe_profile_check(struct rte_sched_pipe_params *params,
> -	uint32_t rate)
> +	uint32_t rate, uint16_t *qsize)
>  {
>  	uint32_t i;
>  
>  	/* Pipe parameters */
>  	if (params == NULL)
> -		return -10;
> +		return -11;

Having used this before, and suffered from the error handling.
Please change this to do proper logging and use a normal convention
for error numbers.  This is not in fast path, it should be more
user friendly.


More information about the dev mailing list