[dpdk-dev] [PATCH] Fix off-by-one errors in snprintf in various files

Thomas Monjalon thomas at monjalon.net
Wed May 29 12:51:15 CEST 2019


10/05/2019 16:55, Bruce Richardson:
> On Fri, May 10, 2019 at 10:53:12AM -0400, Michael Santana wrote:
> > snprintf guarantees to always correctly place a null terminator in the buffer
> > string. So manually placing a null terminator in a buffer right after a call
> > to snprintf is redundant code.
> > 
> > Additionally, there is no need to use 'sizeof(buffer) - 1' in snprintf as this
> > means we are not using the last character in the buffer. 'sizeof(buffer)' is
> > enough.
> > 
> > Cc: stable at dpdk.org
> > 
> > Signed-off-by: Michael Santana <msantana at redhat.com>
> > 
> Looks a good cleanup, thanks.
> 
> Acked-by: Bruce Richardson <bruce.richardson at intel.com>

Applied, thanks





More information about the dev mailing list