[dpdk-dev] [PATCH 25/25] eal: hide shared memory config

[Burakov, Anatoly]

On 29-May-19 5:40 PM, Stephen Hemminger wrote:
> On Wed, 29 May 2019 17:31:11 +0100
> Anatoly Burakov <anatoly.burakov at intel.com> wrote:
> 
>> +static inline void
>> +rte_eal_mcfg_wait_complete(struct rte_mem_config *mcfg)
>> +{
>> +	/* wait until shared mem_config finish initialising */
>> +	while (mcfg->magic != RTE_MAGIC)
>> +		rte_pause();
>> +}
>>
> 
> Not fast path, why is this inline?

I kept existing function. Have no preference one way or the other, can 
change in V2.

> 
>> +#endif // EAL_MEMCFG_H
> 
> Avoid C++ style comments.
> 

Will fix.

-- 
Thanks,
Anatoly