[dpdk-dev] [PATCH v6 10/12] net/i40e: clean LTO build warnings (maybe-uninitialized)

Xing, Beilei beilei.xing at intel.com
Fri Nov 1 03:05:16 CET 2019



> -----Original Message-----
> From: Andrzej Ostruszka [mailto:aostruszka at marvell.com]
> Sent: Tuesday, October 29, 2019 10:12 PM
> To: dev at dpdk.org; Xing, Beilei <beilei.xing at intel.com>; Zhang, Qi Z
> <qi.z.zhang at intel.com>
> Cc: mattias.ronnblom at ericsson.com; stephen at networkplumber.org
> Subject: [PATCH v6 10/12] net/i40e: clean LTO build warnings (maybe-
> uninitialized)
> 
> During LTO build compiler reports some 'false positive' warnings about
> variables being possibly used uninitialized.  This patch silences these warnings.
> 
> Exemplary compiler warning to suppress (with LTO enabled):
> error: ‘filter_idx’ may be used uninitialized in this function [-Werror=maybe-
> uninitialized]
>   PMD_DRV_LOG(INFO, "Added port %d with AQ command with index %d",

Hi,

Thanks for the patch. Please also add fix line here and Cc stable.

> 
> Signed-off-by: Andrzej Ostruszka <aostruszka at marvell.com>
> ---
>  drivers/net/i40e/i40e_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 77a46832c..91d529b2f 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -8480,7 +8480,7 @@ static int
>  i40e_add_vxlan_port(struct i40e_pf *pf, uint16_t port, int udp_type)  {
>  	int  idx, ret;
> -	uint8_t filter_idx;
> +	uint8_t filter_idx = 0;
>  	struct i40e_hw *hw = I40E_PF_TO_HW(pf);
> 
>  	idx = i40e_get_vxlan_port_idx(pf, port);
> --
> 2.17.1



More information about the dev mailing list