[dpdk-dev] [PATCH] vfio: remove deprecated DMA mapping functions

[Damjan Marion (damarion)]

On 27 Oct 2019, at 08:00, Shahaf Shuler <shahafs at mellanox.com<mailto:shahafs at mellanox.com>> wrote:



-----Original Message-----
From: Damjan Marion (damarion) <damarion at cisco.com<mailto:damarion at cisco.com>>
Sent: Friday, October 25, 2019 2:14 PM
To: Thomas Monjalon <thomas at monjalon.net<mailto:thomas at monjalon.net>>
Cc: David Marchand <david.marchand at redhat.com<mailto:david.marchand at redhat.com>>; Anatoly Burakov
<anatoly.burakov at intel.com<mailto:anatoly.burakov at intel.com>>; Shahaf Shuler <shahafs at mellanox.com<mailto:shahafs at mellanox.com>>; Ray
Kinsella <mdr at ashroe.eu<mailto:mdr at ashroe.eu>>; dev <dev at dpdk.org<mailto:dev at dpdk.org>>; Neil Horman
<nhorman at tuxdriver.com<mailto:nhorman at tuxdriver.com>>; John McNamara <john.mcnamara at intel.com<mailto:john.mcnamara at intel.com>>;
Marko Kovacevic <marko.kovacevic at intel.com<mailto:marko.kovacevic at intel.com>>; Bruce Richardson
<bruce.richardson at intel.com<mailto:bruce.richardson at intel.com>>
Subject: Re: [dpdk-dev] [PATCH] vfio: remove deprecated DMA mapping
functions



On 25 Oct 2019, at 00:32, Thomas Monjalon <thomas at monjalon.net<mailto:thomas at monjalon.net>>
wrote:

24/10/2019 21:09, David Marchand:
On Thu, Oct 24, 2019 at 2:18 PM Anatoly Burakov
<anatoly.burakov at intel.com<mailto:anatoly.burakov at intel.com>> wrote:

The rte_vfio_dma_map/unmap API's have been marked as deprecated
in
release 19.05. Remove them.

Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com<mailto:anatoly.burakov at intel.com>>
---

Notes:
  Although `rte_vfio_dma_map` et al. was marked as deprecated in our
documentation,
  it wasn't marked as __rte_deprecated in code. Should we still remove
it?

I can see that vpp is still using this api.
I would prefer we get some ack from their side.

Shahaf?
Ray?

Do you guys have contact with VPP devs?

+Cc Damjan

Thanks for looping me in. If I remember correctly that was used only to get
mlx PMDs working.
We can remove that calls but then mlx PMDs will stop working unless there is
alternative solution.

From my perspective it is not big issue as we already have native rdma based
mlx support, but i would expect that other people will complain.

Is there alternative way to tell DPDK about DMA mapping?

Damjan I don't follow.

Why would using the rte_dev_dma_map would break Mellanox PMDs?

May be just me confused. I remember you guys pot some hack to get it working in the past, but that patch may be using different way to get DMA mappings…