[dpdk-dev] [PATCH] net/ice: fix memory release in FDIR

Wang, ShougangX shougangx.wang at intel.com
Tue Nov 5 07:10:49 CET 2019


Hi, Beilei

> -----Original Message-----
> From: Xing, Beilei
> Sent: Tuesday, November 5, 2019 1:09 PM
> To: Wang, ShougangX <shougangx.wang at intel.com>; dev at dpdk.org
> Cc: Yang, Qiming <qiming.yang at intel.com>; Cao, Yahui
> <yahui.cao at intel.com>; stable at dpdk.org
> Subject: RE: [PATCH] net/ice: fix memory release in FDIR
> 
> 
> 
> > -----Original Message-----
> > From: Wang, ShougangX
> > Sent: Tuesday, November 5, 2019 4:44 AM
> > To: dev at dpdk.org
> > Cc: Yang, Qiming <qiming.yang at intel.com>; Xing, Beilei
> > <beilei.xing at intel.com>; Cao, Yahui <yahui.cao at intel.com>; Wang,
> > ShougangX <shougangx.wang at intel.com>; stable at dpdk.org
> > Subject: [PATCH] net/ice: fix memory release in FDIR
> >
> > To avoid wild pointer and memory leak, following resources management
> > should be added.
> > - Check if the FDIR Memzone already exists before reserving.
> > - Free FDIR memzone when teardown and other failure scenarios.
> > - Set pointers to NULL after free them.
> > - Release all counter resources when teardown.
> 
> Thanks for the patch, but could you split the patch according to different issues?
> 
> Beilei

OK, I will split them in next version.

Thanks.
Shougang


More information about the dev mailing list