[dpdk-dev] [PATCH] vhost: fix batch enqueue only handle few packets

[Liu, Yong]

> -----Original Message-----
> From: Liu, Yong
> Sent: Thursday, November 07, 2019 4:29 PM
> To: Maxime Coquelin <maxime.coquelin at redhat.com>; Bie, Tiwei
> <tiwei.bie at intel.com>; Wang, Zhihong <zhihong.wang at intel.com>
> Cc: dev at dpdk.org
> Subject: RE: [PATCH] vhost: fix batch enqueue only handle few packets
> 
> 
> 
> > -----Original Message-----
> > From: Maxime Coquelin <maxime.coquelin at redhat.com>
> > Sent: Thursday, November 07, 2019 4:20 PM
> > To: Liu, Yong <yong.liu at intel.com>; Bie, Tiwei <tiwei.bie at intel.com>;
> Wang,
> > Zhihong <zhihong.wang at intel.com>
> > Cc: dev at dpdk.org
> > Subject: Re: [PATCH] vhost: fix batch enqueue only handle few packets
> >
> >
> >
> > On 11/7/19 3:37 PM, Marvin Liu wrote:
> > > After enqueue function finished, packet index has been increased.
> Batch
> > > enqueue function should retrieve mbuf structure pointed by that index.
> > >
> > > Fixes: 0294211bb6dc ("vhost: optimize packed ring enqueue")
> > >
> > > Signed-off-by: Marvin Liu <yong.liu at intel.com>
> > > ---
> > >  lib/librte_vhost/virtio_net.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > Applied to dpdk-next-virtio/master
> >
> > Can you please run again the performance benchmarks, and see what is the
> > loss, if any?
> >
> Sure, I will rerun the performance benchmarks.
> 

latest result with gcc9.0.1.
+---------------------------------------------------+
|                                   | 19.08 | + opt |
|-----------------------------------|-------|-------|
| 1518B PvP                         | 2.63M | 3.07M |
|-----------------------------------|-------|-------|
| 64B loopback                      | 7.81M | 12.3M |
|-----------------------------------|-------|-------|
| 1518B loopback                    | 3.59M | 4.54M |
|-----------------------------------|-------|-------|
| 16K chained loopback              | 297K  | 322K  |
|-----------------------------------|-------|-------|
| 50% 256B + 50% 16K                | 688K  | 959K  |
|-----------------------------------|-------|-------|
| pktgen_sample03_burst_single_flow | 5.78M | 5.80M |
+---------------------------------------------------+

> Thanks,
> Marvin
> 
> > Thanks,
> > Maxime