[dpdk-dev] [PATCH 2/2] pdump: use dynamic logtype

[David Marchand]

On Fri, Nov 8, 2019 at 5:39 AM Stephen Hemminger
<stephen at networkplumber.org> wrote:
>
> The logtype USER1 should not be overloaded for library function.
> Instead use a dynamic log type.
>
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>

This patch is incomplete.
$ git grep -w RTE_LOG lib/librte_pdump/
lib/librte_pdump/rte_pdump.c:/* Macro for printing using RTE_LOG */
lib/librte_pdump/rte_pdump.c:                   RTE_LOG(ERR, PDUMP,

== Build lib/librte_pdump
  CC rte_pdump.o
In file included from
/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/x86_64-native-linuxapp-gcc/include/rte_bus.h:24:0,
                 from
/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/x86_64-native-linuxapp-gcc/include/rte_eal.h:21,
                 from
/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/x86_64-native-linuxapp-gcc/include/rte_lcore.h:16,
                 from
/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/x86_64-native-linuxapp-gcc/include/generic/rte_spinlock.h:21,
                 from
/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/x86_64-native-linuxapp-gcc/include/rte_spinlock.h:12,
                 from
/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/x86_64-native-linuxapp-gcc/include/rte_mempool.h:44,
                 from
/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/x86_64-native-linuxapp-gcc/include/rte_mbuf.h:38,
                 from
/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/lib/librte_pdump/rte_pdump.c:6:
/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/lib/librte_pdump/rte_pdump.c:
In function ‘set_pdump_rxtx_cbs’:
/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/x86_64-native-linuxapp-gcc/include/rte_log.h:337:4:
error: ‘RTE_LOGTYPE_PDUMP’ undeclared (first use in this function);
did you mean ‘RTE_LOGTYPE_PMD’?
    RTE_LOGTYPE_ ## t, # t ": " __VA_ARGS__)
    ^
/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/lib/librte_pdump/rte_pdump.c:275:4:
note: in expansion of macro ‘RTE_LOG’
    RTE_LOG(ERR, PDUMP,
    ^~~~~~~
/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/x86_64-native-linuxapp-gcc/include/rte_log.h:337:4:
note: each undeclared identifier is reported only once for each
function it appears in
    RTE_LOGTYPE_ ## t, # t ": " __VA_ARGS__)
    ^
/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/lib/librte_pdump/rte_pdump.c:275:4:
note: in expansion of macro ‘RTE_LOG’
    RTE_LOG(ERR, PDUMP,
    ^~~~~~~
/home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/lib/librte_pdump/rte_pdump.c:
At top level:



-- 
David Marchand