[dpdk-dev] [PATCH v17 08/10] app/testpmd: add command to set supported ptype mask

Ferruh Yigit ferruh.yigit at intel.com
Mon Nov 11 15:51:08 CET 2019


On 11/11/2019 1:19 PM, pbhagavatula at marvell.com wrote:
> From: Pavan Nikhilesh <pbhagavatula at marvell.com>
> 
> Add command to set supported ptype mask.
> Usage:
> 	set port <port_id> ptype_mask <ptype_mask>
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula at marvell.com>

<...>

> +set port supported ptypes
> +~~~~~~~~~~~~~~~~~~~~~~~~~
> +
> +set packet types classification for a specific port::
> +
> +   testpmd> set port (port_id) ptypes_mask (mask)
> +
>  show device info
>  ~~~~~~~~~~~~~~~~
>  

When I run the command [1] on a device that doesn't support it, I am getting:
"Successfully set following ptypes for Port 0"

I still think this is wrong and we should fix it, and introduce '-ENOTSUP' to
'rte_eth_dev_set_ptypes()' as other APIs. Since the API is experimental we can
do it later for sake of making the set for rc2.

Can we please keep tracing the discussion for this one for rc3?

[1]
testpmd> set port 0 ptype_mask 0


More information about the dev mailing list