[dpdk-dev] [PATCH v16 4/8] drivers/net: update Rx RSS hash offload capabilities

[Ferruh Yigit]

On 11/8/2019 8:48 AM, Andrew Rybchenko wrote:
> On 11/7/19 8:22 PM, Ferruh Yigit wrote:
>> On 11/6/2019 7:17 PM, pbhagavatula at marvell.com wrote:
>>> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
>>> index ed8cbd849..37df1c40a 100644
>>> --- a/drivers/net/i40e/i40e_ethdev.c
>>> +++ b/drivers/net/i40e/i40e_ethdev.c
>>> @@ -1812,6 +1812,8 @@ i40e_dev_configure(struct rte_eth_dev *dev)
>>>  	ad->tx_simple_allowed = true;
>>>  	ad->tx_vec_allowed = true;
>>>  
>>> +	dev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH;
>>> +
>>>  	/* Only legacy filter API needs the following fdir config. So when the
>>>  	 * legacy filter API is deprecated, the following codes should also be
>>>  	 * removed.
>>
>> When I checked with "show port 0 rx_offload configuration" testpmd command, I
>> don't see that "RSS_HASH" is shown as enabled, do you know why it doesn't show up?
> 
> As I understand testpmd uses its own internal dev_conf copy,
> not dev->data->dev_conf.
> 

Yes, because device config is device internal application seems keeping its own
copy, and since the PMD updates the configuration on its own the application
config and PMD config diverges.