[dpdk-dev] [dpdk-stable] [PATCH 2/2] malloc: fix realloc padded element size

[Xueming(Steven) Li]

> -----Original Message-----
> From: David Marchand <david.marchand at redhat.com>
> Sent: Wednesday, November 20, 2019 4:47 AM
> To: Xueming(Steven) Li <xuemingl at mellanox.com>; Anatoly Burakov
> <anatoly.burakov at intel.com>
> Cc: Asaf Penso <asafp at mellanox.com>; dev <dev at dpdk.org>; dpdk stable
> <stable at dpdk.org>
> Subject: Re: [dpdk-stable] [PATCH 2/2] malloc: fix realloc padded element
> size
> 
> On Tue, Nov 12, 2019 at 3:50 PM Xueming Li <xuemingl at mellanox.com>
> wrote:
> >
> > When resize a memory with next element, the original element size grows.
> > If the orginal element has padding, the real inner element size didn't
> > grow as well and this causes trailer verification failure when malloc
> > debug enabled.
> 
> I did not see this when running the malloc_autotest with debug enabled.
> What is missing for me to catch it?
> 
Yes, it happens rarely, depends on memory fragment. I only caught this in middle of a long test.

> 
> Just a bit chilly to apply this series.
> The first patch seems an optimisation.
> The second one seems more interesting if we fix the debug mode, but I
> suppose we can live without them in 19.11.
Few people enable memory debug option, they are there for years.

> 
> 
> --
> David Marchand