[dpdk-dev] [PATCH] mbuf: display more fields in dump

[Stephen Hemminger]

On Thu, 21 Nov 2019 17:16:42 +0100
Morten Brørup <mb at smartsharesystems.com> wrote:

> Are all these explicit type casts really needed? buf_iova is already uint64_t, buflen is uint16_t, data_off is uint16_t, rte_mbuf_refcnt_read() returns uint16_t, pkt_len is uint32_t, nb_segs is uint16_t, port is uint16_t, vlan_tci is uint16_t.

Normally, they are not needed.
If you turn up some of the warning levels in Gcc, then yes.

> 
> m->port is not only the input port anymore (ref. the mbuf documentation), so please change in_port=%u to port=%u.

Makes sense, but since this in internal would rather keep existing
 to print the name of the field.

> 
> For consistency with ol_flags and vlan_tci format, consider changing iova=% to iova=%#.

good idea, personal preference is to always use %#x over %x