[dpdk-dev] [PATCH 4/6] crypto/octeontx2: add asymmetric in enqueue/dequeue ops

[Anoob Joseph]

Hi Akhil,

PMD doesn't support sessionless with ASYM yet. Will make the suggested change in v2.

Thanks,
Anoob

> -----Original Message-----
> From: dev <dev-bounces at dpdk.org> On Behalf Of Akhil Goyal
> Sent: Tuesday, October 1, 2019 7:42 PM
> To: Anoob Joseph <anoobj at marvell.com>; Pablo de Lara
> <pablo.de.lara.guarch at intel.com>; Thomas Monjalon <thomas at monjalon.net>
> Cc: Sunila Sahu <ssahu at marvell.com>; Jerin Jacob Kollanukkaran
> <jerinj at marvell.com>; Narayana Prasad Raju Athreya
> <pathreya at marvell.com>; Fiona Trahe <fiona.trahe at intel.com>; Kanaka Durga
> Kotamarthy <kkotamarthy at marvell.com>; Shally Verma
> <shallyv at marvell.com>; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 4/6] crypto/octeontx2: add asymmetric in
> enqueue/dequeue ops
> 
> 
> Hi Anoob,
> 
> >  static __rte_always_inline int __hot
> >  otx2_cpt_enqueue_sym(struct otx2_cpt_qp *qp, struct rte_crypto_op *op,
> >  		     struct pending_queue *pend_q)
> > @@ -488,7 +560,9 @@ otx2_cpt_enqueue_burst(void *qptr, struct
> > rte_crypto_op **ops, uint16_t nb_ops)
> >
> >  	for (count = 0; count < nb_ops; count++) {
> >  		op = ops[count];
> > -		if (op->sess_type == RTE_CRYPTO_OP_WITH_SESSION)
> > +		if (op->type == RTE_CRYPTO_OP_TYPE_ASYMMETRIC)
> > +			ret = otx2_cpt_enqueue_asym(qp, op, pend_q);
> > +		else if (op->sess_type == RTE_CRYPTO_OP_WITH_SESSION)
> >  			ret = otx2_cpt_enqueue_sym(qp, op, pend_q);
> >  		else if (op->sess_type == RTE_CRYPTO_OP_SESSIONLESS)
> >  			ret = otx2_cpt_enqueue_sym_sessless(qp, op, pend_q);
> 
> Do you support session less in asym case? If not, can we add a check here.
>