[dpdk-dev] [PATCH v3 0/3] net/bnx2x: update to latest FW

Jerin Jacob jerinjacobk at gmail.com
Thu Oct 3 07:57:19 CEST 2019


On Thu, Oct 3, 2019 at 12:45 AM Rasesh Mody <rmody at marvell.com> wrote:
>
> Hi,
>
> Currently, BNX2X PMD uses a very old firmware 7.2.51.
> This patch series updated the base driver to use to latest
> firmware 7.13.11. The latest firmware comprises of enhancements
> and fixes.
>
> v3:
> - Addressed gcc 9.2 build issues
> v2:
> - Squashed pmd version patch into "net/bnx2x: update to latest FW 7.13.11"
> - Addressed most of checkpatch issues
>
> Thanks!
> -Rasesh
>
> Rasesh Mody (3):
>   net/bnx2x: update and reorganize HW registers
>   net/bnx2x: update HSI code
>   net/bnx2x: update to latest FW 7.13.11

I don't think this patch comes as _base_ code, Please fix the trivial
and genuine check path errors.

[master][dpdk-next-net-mrvl] $ ./devtools/checkpatches.sh

### net/bnx2x: update HSI code

WARNING:TYPO_SPELLING: 'entires' may be misspelled - perhaps 'entries'?
#863: FILE: drivers/net/bnx2x/ecore_hsi.h:2844:
+       /* 9 entires for the C2S PCP map for each inner VLAN PCP + 1 default */

total: 0 errors, 1 warnings, 0 checks, 5425 lines checked

### net/bnx2x: update to latest FW 7.13.11

CHECK:CAMELCASE: Avoid CamelCase: <assertListEntry>
#174: FILE: drivers/net/bnx2x/ecore_fw_defs.h:18:
+       (IRO[151].base + ((assertListEntry) * IRO[151].m1))

CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV)
#178: FILE: drivers/net/bnx2x/ecore_fw_defs.h:20:
+       (IRO[157].base + (((pfId)>>1) * IRO[157].m1) + (((pfId)&1) * \
                                 ^

CHECK:SPACING: spaces preferred around that '&' (ctx:VxV)
#178: FILE: drivers/net/bnx2x/ecore_fw_defs.h:20:
+       (IRO[157].base + (((pfId)>>1) * IRO[157].m1) + (((pfId)&1) * \
                                                               ^

CHECK:CAMELCASE: Avoid CamelCase: <pfId>
#178: FILE: drivers/net/bnx2x/ecore_fw_defs.h:20:
+       (IRO[157].base + (((pfId)>>1) * IRO[157].m1) + (((pfId)&1) * \

CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV)
#189: FILE: drivers/net/bnx2x/ecore_fw_defs.h:23:
+       (IRO[158].base + (((pfId)>>1) * IRO[158].m1) + (((pfId)&1) * \
                                 ^

CHECK:SPACING: spaces preferred around that '&' (ctx:VxV)
#189: FILE: drivers/net/bnx2x/ecore_fw_defs.h:23:
+       (IRO[158].base + (((pfId)>>1) * IRO[158].m1) + (((pfId)&1) * \
                                                               ^

CHECK:CAMELCASE: Avoid CamelCase: <funcId>
#193: FILE: drivers/net/bnx2x/ecore_fw_defs.h:26:
+       (IRO[163].base + ((funcId) * IRO[163].m1))

CHECK:CAMELCASE: Avoid CamelCase: <hcIndex>
#199: FILE: drivers/net/bnx2x/ecore_fw_defs.h:30:
+       (IRO[143].base + ((hcIndex) * IRO[143].m1) + ((sbId) * IRO[143].m2))

CHECK:CAMELCASE: Avoid CamelCase: <sbId>
#199: FILE: drivers/net/bnx2x/ecore_fw_defs.h:30:
+       (IRO[143].base + ((hcIndex) * IRO[143].m1) + ((sbId) * IRO[143].m2))

CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV)
#204: FILE: drivers/net/bnx2x/ecore_fw_defs.h:32:
+       (IRO[142].base + (((hcIndex)>>2) * IRO[142].m1) + (((hcIndex)&3) \
                                    ^

CHECK:SPACING: spaces preferred around that '&' (ctx:VxV)
#204: FILE: drivers/net/bnx2x/ecore_fw_defs.h:32:
+       (IRO[142].base + (((hcIndex)>>2) * IRO[142].m1) + (((hcIndex)&3) \

CHECK:CAMELCASE: Avoid CamelCase: <iscsiEqId>


                  [65/1889]
#215: FILE: drivers/net/bnx2x/ecore_fw_defs.h:40:
+       (IRO[316].base + ((pfId) * IRO[316].m1) + ((iscsiEqId) * IRO[316].m2))

CHECK:CAMELCASE: Avoid CamelCase: <vfId>
#287: FILE: drivers/net/bnx2x/ecore_fw_defs.h:87:
+#define CSTORM_VF_PF_CHANNEL_STATE_OFFSET(vfId) \

CHECK:CAMELCASE: Avoid CamelCase: <portId>
#368: FILE: drivers/net/bnx2x/ecore_fw_defs.h:142:
+       (IRO[187].base + ((portId) * IRO[187].m1))

CHECK:CAMELCASE: Avoid CamelCase: <clientId>
#414: FILE: drivers/net/bnx2x/ecore_fw_defs.h:172:
+       (IRO[215].base + ((portId) * IRO[215].m1) + ((clientId) * \

CHECK:CAMELCASE: Avoid CamelCase: <qzoneId>
#420: FILE: drivers/net/bnx2x/ecore_fw_defs.h:175:
+       (IRO[216].base + ((qzoneId) * IRO[216].m1))

CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV)
#498: FILE: drivers/net/bnx2x/ecore_fw_defs.h:241:
+       (IRO[220].base + (((pfId)>>1) * IRO[220].m1) + (((pfId)&1) * \
                                 ^

CHECK:SPACING: spaces preferred around that '&' (ctx:VxV)
#498: FILE: drivers/net/bnx2x/ecore_fw_defs.h:241:
+       (IRO[220].base + (((pfId)>>1) * IRO[220].m1) + (((pfId)&1) * \
                                                               ^

CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#526: FILE: drivers/net/bnx2x/ecore_fw_defs.h:268:
+       (0xFFFF - ((PAGE_SIZE/((STRUCT_SIZE(eth_rx_sge))/8))-1))
                             ^

CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#526: FILE: drivers/net/bnx2x/ecore_fw_defs.h:268:
+       (0xFFFF - ((PAGE_SIZE/((STRUCT_SIZE(eth_rx_sge))/8))-1))
                                                        ^

CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#526: FILE: drivers/net/bnx2x/ecore_fw_defs.h:268:
+       (0xFFFF - ((PAGE_SIZE/((STRUCT_SIZE(eth_rx_sge))/8))-1))
                                                            ^

CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#530: FILE: drivers/net/bnx2x/ecore_fw_defs.h:272:
+#define U_ETH_SGES_PER_PAGE (PAGE_SIZE/(STRUCT_SIZE(eth_rx_sge)/8))
                                       ^

CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#530: FILE: drivers/net/bnx2x/ecore_fw_defs.h:272:
+#define U_ETH_SGES_PER_PAGE (PAGE_SIZE/(STRUCT_SIZE(eth_rx_sge)/8))
                                                                ^

CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#534: FILE: drivers/net/bnx2x/ecore_fw_defs.h:276:
+#define U_ETH_SGES_PER_PAGE_MASK (U_ETH_SGES_PER_PAGE-1)




                  [16/1889]
CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#530: FILE: drivers/net/bnx2x/ecore_fw_defs.h:272:
+#define U_ETH_SGES_PER_PAGE (PAGE_SIZE/(STRUCT_SIZE(eth_rx_sge)/8))
                                                                ^

CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#534: FILE: drivers/net/bnx2x/ecore_fw_defs.h:276:
+#define U_ETH_SGES_PER_PAGE_MASK (U_ETH_SGES_PER_PAGE-1)
                                                      ^

CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#577: FILE: drivers/net/bnx2x/ecore_fw_defs.h:378:
+#define TSDM_TIMER_TICK_RESUL_CHIP (1 * (1e-6))
                                            ^

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'r_order
== MAX_RD_ORD'
#1119: FILE: drivers/net/bnx2x/ecore_init_ops.h:499:
+       if ((CHIP_IS_E1(sc) || CHIP_IS_E1H(sc)) && (r_order == MAX_RD_ORD))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
#1537: FILE: drivers/net/bnx2x/ecore_sp.h:138:
+#define ECORE_ILT_ZALLOC(x, y, size)                           \
        do {                                                            \
                x = rte_malloc("", sizeof(struct bnx2x_dma),
RTE_CACHE_LINE_SIZE); \
                if (x) {                                                \
                        if (bnx2x_dma_alloc((struct bnx2x_softc *)sc,   \
                                          size, (struct bnx2x_dma *)x,  \
+                                         "ILT", RTE_CACHE_LINE_SIZE) != 0) { \
                                rte_free(x);                            \
                                x = NULL;                               \
+                               *(y) = 0;                               \
                        } else {                                        \
                                *y = ((struct bnx2x_dma *)x)->paddr;    \
                        }                                               \

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'y' - possible side-effects?
#1537: FILE: drivers/net/bnx2x/ecore_sp.h:138:
+#define ECORE_ILT_ZALLOC(x, y, size)                           \
        do {                                                            \
                x = rte_malloc("", sizeof(struct bnx2x_dma),
RTE_CACHE_LINE_SIZE); \
                if (x) {                                                \
                        if (bnx2x_dma_alloc((struct bnx2x_softc *)sc,   \
                                          size, (struct bnx2x_dma *)x,  \
+                                         "ILT", RTE_CACHE_LINE_SIZE) != 0) { \
                                rte_free(x);                            \
                                x = NULL;                               \
+                               *(y) = 0;                               \
                        } else {                                        \
                                *y = ((struct bnx2x_dma *)x)->paddr;    \
                        }                                               \

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sc' - possible side-effects?
#2191: FILE: drivers/net/bnx2x/ecore_sp.h:1967:
+#define PF_MAC_CREDIT_E2(sc, func_num)                                 \
+       ((MAX_MAC_CREDIT_E2 - GET_NUM_VFS_PER_PATH(sc) * VF_MAC_CREDIT_CNT) / \
+        (func_num) + GET_NUM_VFS_PER_PF(sc) * VF_MAC_CREDIT_CNT)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sc' - possible side-effects?


>
>  doc/guides/nics/bnx2x.rst          |    4 +-
>  drivers/net/bnx2x/bnx2x.c          |   63 +-
>  drivers/net/bnx2x/bnx2x.h          |   95 +-
>  drivers/net/bnx2x/bnx2x_osal.h     |   29 +
>  drivers/net/bnx2x/bnx2x_rxtx.c     |   10 +-
>  drivers/net/bnx2x/ecore_fw_defs.h  |  252 +-
>  drivers/net/bnx2x/ecore_hsi.h      | 3508 ++++++++-------
>  drivers/net/bnx2x/ecore_init.h     |  214 +-
>  drivers/net/bnx2x/ecore_init_ops.h |  192 +-
>  drivers/net/bnx2x/ecore_mfw_req.h  |   11 +-
>  drivers/net/bnx2x/ecore_reg.h      | 6617 +++++++++++++++++++---------
>  drivers/net/bnx2x/ecore_sp.c       |   48 +-
>  drivers/net/bnx2x/ecore_sp.h       |  308 +-
>  13 files changed, 7185 insertions(+), 4166 deletions(-)
>  create mode 100644 drivers/net/bnx2x/bnx2x_osal.h
>
> --
> 2.18.0
>


More information about the dev mailing list