[dpdk-dev] [PATCH] devtools: reset compilation flags for each target

[Bruce Richardson]

On Wed, Oct 02, 2019 at 06:55:47PM +0200, David Marchand wrote:
> Same idea than overriding PATH and PKG_CONFIG_PATH, it can be quite
> useful to override compilation flags like CFLAGS, CPPFLAGS and LDFLAGS
> for cross compilation or libraries that won't provide a pkg-config file.
> 
> Fixes: 272236741258 ("devtools: load target-specific compilation environment")
> 
> Signed-off-by: David Marchand <david.marchand at redhat.com>
> ---

No strong objection to this change, but for meson the better way to handle
this may be to put these flags into the cross-file used for the build. By
explicitly passing CFLAGS etc. to the build, I'm not sure what the
behaviour is with regards to passing those flags to cross-built vs
native-built components. For a cross-compile, not all CFLAGS should be
passed to the build of pmdinfogen, for instance.

/Bruce