[dpdk-dev] [PATCH 0/5] some bbdev cleanups

Bruce Richardson bruce.richardson at intel.com
Fri Oct 4 19:19:08 CEST 2019


As pointed out in the discussion of the patchset for building shared and
static libraries separately [1], the test_bbdev_perf.c file explicitly
disables some code for shared library builds. This is due to functions
not being properly exported from one of the baseband drivers.

While fixing this and looking to remove the #ifdef for shared libraries,
it was discovered that the per-driver macro used in that file was
incorrect for use in the meson build due to inconsistencies of naming
between the two builds.

Therefore, this set adjusts the macros and names of the drivers so that
they are consistent across drivers, and between both meson and make.
Thereafter the missing function for the fpga_lte_fec driver is exported
and the #ifdef removed from the code.

After these patches are replied, the only instance of the
RTE_BUILD_SHARED_LIB macro used in .c/.h file is in rte_compat.h for
function versioning support.

[1] http://patches.dpdk.org/project/dpdk/list/?series=6596

Bruce Richardson (5):
  drivers/baseband: align meson defines with make
  baseband/fpga_lte_fec: align naming to other bbdevs
  drivers/baseband: remove override of driver names
  baseband/fpga_lte_fec: add public API to map file
  app/test-bbdev: enable fpga_lte_fec support in shared builds

 app/test-bbdev/Makefile                                   | 3 +++
 app/test-bbdev/meson.build                                | 6 +++---
 app/test-bbdev/test_bbdev_perf.c                          | 8 +++-----
 config/common_base                                        | 2 +-
 doc/guides/bbdevs/fpga_lte_fec.rst                        | 2 +-
 drivers/baseband/Makefile                                 | 2 +-
 drivers/baseband/fpga_lte_fec/Makefile                    | 6 +++---
 drivers/baseband/fpga_lte_fec/fpga_lte_fec.h              | 1 +
 drivers/baseband/fpga_lte_fec/meson.build                 | 1 -
 .../fpga_lte_fec/rte_pmd_bbdev_fpga_lte_fec_version.map   | 4 ++++
 drivers/baseband/meson.build                              | 4 ++--
 drivers/baseband/null/meson.build                         | 1 -
 drivers/baseband/turbo_sw/meson.build                     | 1 -
 mk/rte.app.mk                                             | 2 +-
 14 files changed, 23 insertions(+), 20 deletions(-)

-- 
2.21.0



More information about the dev mailing list