[dpdk-dev] [PATCH v2 4/4] drivers: remove duplicated compiler flags

Bruce Richardson bruce.richardson at intel.com
Mon Oct 7 16:30:13 CEST 2019


Now that -Wextra, and other warning flags are standard in the build, remove
any duplication in driver build specifications.

Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
Acked-by: Luca Boccassi <bluca at debian.org>
---
 drivers/net/fm10k/base/meson.build  | 2 +-
 drivers/net/mlx4/meson.build        | 1 -
 drivers/net/mlx5/meson.build        | 1 -
 drivers/net/sfc/meson.build         | 2 --
 drivers/net/vdev_netvsc/meson.build | 2 --
 5 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/net/fm10k/base/meson.build b/drivers/net/fm10k/base/meson.build
index 9e1022fef..40d9b730a 100644
--- a/drivers/net/fm10k/base/meson.build
+++ b/drivers/net/fm10k/base/meson.build
@@ -12,7 +12,7 @@ sources = [
 
 error_cflags = ['-Wno-unused-parameter', '-Wno-unused-value',
 	'-Wno-strict-aliasing', '-Wno-format-extra-args',
-	'-Wno-unused-variable', '-Wno-missing-field-initializers',
+	'-Wno-unused-variable',
 	'-Wno-implicit-fallthrough'
 ]
 c_args = cflags
diff --git a/drivers/net/mlx4/meson.build b/drivers/net/mlx4/meson.build
index efee45776..873edadac 100644
--- a/drivers/net/mlx4/meson.build
+++ b/drivers/net/mlx4/meson.build
@@ -55,7 +55,6 @@ if build
 		sources += files('mlx4_glue.c')
 	endif
 	cflags_options = [
-		'-Wextra',
 		'-std=c11',
 		'-Wno-strict-prototypes',
 		'-D_BSD_SOURCE',
diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build
index 3c5144c9b..94f92ad6b 100644
--- a/drivers/net/mlx5/meson.build
+++ b/drivers/net/mlx5/meson.build
@@ -66,7 +66,6 @@ if build
 		sources += files('mlx5_glue.c')
 	endif
 	cflags_options = [
-		'-Wextra',
 		'-std=c11',
 		'-Wno-strict-prototypes',
 		'-D_BSD_SOURCE',
diff --git a/drivers/net/sfc/meson.build b/drivers/net/sfc/meson.build
index 4fb0d0ac1..8c54f9d54 100644
--- a/drivers/net/sfc/meson.build
+++ b/drivers/net/sfc/meson.build
@@ -20,14 +20,12 @@ extra_flags += '-Wno-strict-aliasing'
 
 # Enable more warnings
 extra_flags += [
-	'-Wextra',
 	'-Wdisabled-optimization'
 ]
 
 # Compiler and version dependent flags
 extra_flags += [
 	'-Waggregate-return',
-	'-Wnested-externs',
 	'-Wbad-function-cast'
 ]
 
diff --git a/drivers/net/vdev_netvsc/meson.build b/drivers/net/vdev_netvsc/meson.build
index c82c5476c..bf62edb7a 100644
--- a/drivers/net/vdev_netvsc/meson.build
+++ b/drivers/net/vdev_netvsc/meson.build
@@ -10,8 +10,6 @@ sources = files('vdev_netvsc.c')
 allow_experimental_apis = true
 
 cflags_options = [
-        '-Wall',
-        '-Wextra',
         '-D_BSD_SOURCE',
         '-D_DEFAULT_SOURCE',
         '-D_XOPEN_SOURCE=600'
-- 
2.21.0



More information about the dev mailing list