[dpdk-dev] [PATCH v5 4/5] mbuf: add a pktmbuf copy routine

Stephen Hemminger stephen at networkplumber.org
Tue Oct 8 17:27:59 CEST 2019


On Tue, 8 Oct 2019 11:03:34 +0200
Olivier Matz <olivier.matz at 6wind.com> wrote:

> >  
> > +/**
> > + * Creates a full copy of a given packet mbuf.  
> 
> Although it's not consistent everywhere, I think the imperative
> form is preferred ("Create" instead of "Creates").
> 
> > + * Copies all the data from a given packet mbuf to a newly allocated
> > + * set of mbufs.  
> 
> Same here
> 
> > + *
> > + * @param m
> > + *   The packet mbuf to be cloned.  
> 
> cloned -> copied (there are some other occurrences of "clone" below)


This comment was modified from the mbuf_clone description.
The two should use same grammar. Don't really care which way
but should be consistent between these two.

Will fix both to match your suggestion.


More information about the dev mailing list