[dpdk-dev] [PATCH 10/10] crypto/dpaa_sec: code reorg for better session mgmt

[Hemant Agrawal]

Hi Aaron,
	Thanks!
I will fix these comments.
Regards,
Hemant

> -----Original Message-----
> From: Aaron Conole <aconole at redhat.com>
> Sent: Saturday, October 12, 2019 12:34 AM
> To: Hemant Agrawal <hemant.agrawal at nxp.com>
> Cc: dev at dpdk.org; Akhil Goyal <akhil.goyal at nxp.com>
> Subject: Re: [dpdk-dev] [PATCH 10/10] crypto/dpaa_sec: code reorg for
> better session mgmt
> Importance: High
> 
> Hemant Agrawal <hemant.agrawal at nxp.com> writes:
> 
> > The session related parameters shall be populated during the session
> > create only.
> > At the runtime on first packet, the CDB should just reference the
> > session data instead of re-interpreting data again.
> >
> > Signed-off-by: Hemant Agrawal <hemant.agrawal at nxp.com>
> > ---
> 
> As a part of this patch, a number of static functions are no longer used, and
> should be removed (for example is_auth_only, is_cipher_only, is_aead,
> is_auth_cipher, and is_proto_ipsec).
> 
> You will see this if you choose to build with clang.  gcc sees the functions
> marked as static inline, and doesn't seem to warn.
>