[dpdk-dev] [PATCH v3 2/2] net/virtio: do not require IO permissions

Tiwei Bie tiwei.bie at intel.com
Wed Oct 23 06:56:54 CEST 2019


On Tue, Oct 22, 2019 at 10:21:43AM +0200, David Marchand wrote:
> On x86, iopl permissions are only available to root user (or users that
> have the CAP_SYS_RAWIO capability).
> But those permissions are only needed when the virtio devices accesses
> are done with inb/outb instructions, which is when the device is bound
> to a UIO kernel module.
> 
> So far, the virtio driver was refusing to register based on the check
> on IO permissions.
> This check does not make sense when binding the device to vfio.
> 
> Now that the check on IO permissions has been abstracted in the ioport
> API, we can remove it on virtio side.
> 
> We still need to call rte_eal_iopl_init() in the virtio constructor so
> that the interrupt thread inherits this permission in the case it could
> be used with UIO later.
> 
> Signed-off-by: David Marchand <david.marchand at redhat.com>
> Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>
> ---

Acked-by: Tiwei Bie <tiwei.bie at intel.com>

Thanks,
Tiwei


More information about the dev mailing list