[dpdk-dev] [RFC v2 1/3] ethdev: add the API for getting trace information

Thomas Monjalon thomas at monjalon.net
Sat Oct 26 18:45:37 CEST 2019


13/08/2019 14:51, Ray Kinsella:
> On 13/08/2019 04:24, Stephen Hemminger wrote:
> > On Tue, 13 Aug 2019 11:06:10 +0800
> > Haiyue Wang <haiyue.wang at intel.com> wrote:
> > 
> >> Enhance the PMD to support retrieving trace information like
> >> Rx/Tx burst selection etc.
> >>
> >> Signed-off-by: Haiyue Wang <haiyue.wang at intel.com>
[...]
> >>  int
> >> +rte_eth_trace_info_get(uint16_t port_id, uint16_t queue_id,
> >> +		       enum rte_eth_trace type, char *buf, int sz)
[...]
> > The bigger problem is that this information is like a log message
> > and unstructured, which makes it device specific and useless for automation.
> 
> IMHO - this is much better implemented as a capability bitfield, that
> can be queried.

Now I see where this idea comes from.
Ray, Stephen, structuring shuch information is really a bad idea.
The Rx/Tx functions are not like capabilities, they are full of smart
tricks written by brillant engineers. Please do not try to put ideas
in some categories. We will have more and more new types of optimization
and ideas when the hardware will evolve.

And, more importantly, there is no need of automation or processing
with this information.




More information about the dev mailing list