[dpdk-dev] [PATCH v6] app/testpmd: enable GTP header parse and Tx checksum offload

Xu, Ting ting.xu at intel.com
Mon Oct 28 02:35:11 CET 2019


Hi, Thomas, 

Sorry for my mistake about missing meson.build. I have fixed it as well as others based on your comments.
However, I am not quite understand your last reply. Do I still need to send a new patch now or not?

Thanks for your patient help!

Best Regards,
Ting Xu

-----Original Message-----
From: Thomas Monjalon <thomas at monjalon.net> 
Sent: Saturday, October 26, 2019 6:49 AM
To: Xu, Ting <ting.xu at intel.com>
Cc: dev at dpdk.org; Lu, Wenzhuo <wenzhuo.lu at intel.com>; Wu, Jingjing <jingjing.wu at intel.com>; Iremonger, Bernard <bernard.iremonger at intel.com>; olivier.matz at 6wind.com; Yigit, Ferruh <ferruh.yigit at intel.com>
Subject: Re: [dpdk-dev] [PATCH v6] app/testpmd: enable GTP header parse and Tx checksum offload

22/10/2019 18:26, Ting Xu:
> This patch enables testpmd to forward GTP packet in csum fwd mode.
> A GTP header structure (without optional fields and extension header) 
> is defined in new rte_gtp.h. A parser function in testpmd is added.
> GTPU and GTPC packets are both supported, with respective UDP 
> destination port and GTP message type.
> 
> Signed-off-by: Ting Xu <ting.xu at intel.com>
> 
> ---
> v6: complete doxygen documentation.
> v5: create rte_gtp.h and move GTP header definition to it.
> v4: move GTP header definition to rte_ether.h
> v3: correct coding style issue.
> v2: modify commit log
> 
> depend on patch: lib/mbuf: add GTP tunnel type flag.
> ---
>  app/test-pmd/csumonly.c   | 97 +++++++++++++++++++++++++++++++++++----
>  doc/api/doxy-api-index.md |  1 +
>  lib/librte_net/Makefile   |  2 +-

You missed meson.build in addition of Makefile.

>  lib/librte_net/rte_gtp.h  | 52 +++++++++++++++++++++
>  4 files changed, 141 insertions(+), 11 deletions(-)  create mode 
> 100644 lib/librte_net/rte_gtp.h

Does it deserve 2 separate patches? GTP header + testpmd use

[...]
> --- /dev/null
> +++ b/lib/librte_net/rte_gtp.h
[...]
> +
> +#endif /* RTE_GTP_H_ */
> +

Please remove this blank line at EOF. Such things are cleaned up sometimes:
	http://git.dpdk.org/dpdk/commit/?id=6f3f0acd95




More information about the dev mailing list