[dpdk-dev] [PATCH v2 01/10] build: add an option to enable LTO build

Thomas Monjalon thomas at monjalon.net
Mon Oct 28 18:16:19 CET 2019


28/10/2019 13:12, Andrzej Ostruszka:
> On 10/28/19 9:36 AM, Andrzej Ostruszka wrote:
> > On 10/27/19 12:31 PM, Thomas Monjalon wrote:
> [...]
> >> Should we document its use in rte_function_versioning.h
> >> and versioning.rst?
> > 
> > Yes, I think so.  I'll add that.
> 
> One quick notice.  There is a slight mismatch between documentation of
> VERSION_SYMBOL/BIND_DEFAULT_SYMBOL and their implementation i.e. the
> docs claim that the underscore is added by these macros (b_e) while it
> is currently being supplied at the macro invocations.
> 
> I'll try to update docs to match the header but if you'd like to change
> it the other way* please let me know.
> 
> Regards
> Andrzej
> 
> [*] Change the implementation of these macros to use:
>     ... RTE_STR(b) "_" RTE_STR(e)
>   and remove underscore from all invocations of these macros.

Please do the doc fix in a separate patch, Cc'ing Neil Horman
who can decide what is best.
Thanks




More information about the dev mailing list