[dpdk-dev] [PATCH v4] ethdev: extend flow metadata

Slava Ovsiienko viacheslavo at mellanox.com
Tue Oct 29 19:35:24 CET 2019


> -----Original Message-----
> From: Thomas Monjalon <thomas at monjalon.net>
> Sent: Tuesday, October 29, 2019 20:30
> To: Slava Ovsiienko <viacheslavo at mellanox.com>
> Cc: Andrew Rybchenko <arybchenko at solarflare.com>; dev at dpdk.org;
> Matan Azrad <matan at mellanox.com>; olivier.matz at 6wind.com; Ori Kam
> <orika at mellanox.com>
> Subject: Re: [dpdk-dev] [PATCH v4] ethdev: extend flow metadata
> 
> 29/10/2019 18:19, Slava Ovsiienko:
> > From: Andrew Rybchenko <arybchenko at solarflare.com>
> > > > --- a/doc/guides/rel_notes/deprecation.rst
> > > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > > +* ethdev: DEV_TX_OFFLOAD_MATCH_METADATA will be removed,
> static
> > > > +metadata
> > > > +  mbuf field will be removed in 20.02, metadata feature will use
> > > > +dynamic mbuf
> > > > +  field and flag instead.
> > > > +
> > >
> > > Isn't it breaking stable API/ABI? Should target release be 20.11?
> >
> > tx_metadata is in union, it should not be ABI break.
> > And we propose to remove tx_metadata at all in 19.11 and share the
> > dynamic metadata field between Rx and Tx METAdata.
> 
> Yes please, let's remove tx_metadata from mbuf now, while adding
> metadata dynamic field.
> I am sure nobody will complain that we sanitized this feature before
> releasing DPDK 19.11 LTS.

OK, I'll extend this patch to small series and update tx_metadata in the
dedicated commit (to simplify reviewing either).

With best regards, Slava
 



More information about the dev mailing list