[dpdk-dev] [dpdk-stable] [PATCH 6/9] net/ipn3ke: remove commented out code

David Marchand david.marchand at redhat.com
Wed Oct 30 09:04:01 CET 2019


On Tue, Oct 1, 2019 at 3:04 PM Kevin Traynor <ktraynor at redhat.com> wrote:
>
> These struct members and variable were commented out. Remove them.
>
> Fixes: c01c748e4ae6 ("net/ipn3ke: add new driver")
> Fixes: c820468ac99c ("net/ipn3ke: support TM")
> Cc: rosen.xu at intel.com
> Cc: stable at dpdk.org
>
> Signed-off-by: Kevin Traynor <ktraynor at redhat.com>
> ---
>  drivers/net/ipn3ke/ipn3ke_ethdev.h | 7 -------
>  drivers/net/ipn3ke/ipn3ke_tm.c     | 1 -
>  2 files changed, 8 deletions(-)
>
> diff --git a/drivers/net/ipn3ke/ipn3ke_ethdev.h b/drivers/net/ipn3ke/ipn3ke_ethdev.h
> index c7b336bbd..0d71dcd64 100644
> --- a/drivers/net/ipn3ke/ipn3ke_ethdev.h
> +++ b/drivers/net/ipn3ke/ipn3ke_ethdev.h
> @@ -97,18 +97,11 @@ struct ipn3ke_tm_node {
>  struct ipn3ke_tm_hierarchy {
>         struct ipn3ke_tm_node *port_node;
> -       /*struct ipn3ke_tm_node_list vt_node_list;*/
> -       /*struct ipn3ke_tm_node_list cos_node_list;*/
> -
>         uint32_t n_shaper_profiles;
> -       /*uint32_t n_shared_shapers;*/
>         uint32_t n_tdrop_profiles;
>         uint32_t n_vt_nodes;
>         uint32_t n_cos_nodes;
> -
>         struct ipn3ke_tm_node *port_commit_node;
>         struct ipn3ke_tm_node_list vt_commit_node_list;
>         struct ipn3ke_tm_node_list cos_commit_node_list;
> -
> -       /*uint32_t n_tm_nodes[IPN3KE_TM_NODE_LEVEL_MAX];*/
>  };
>
> diff --git a/drivers/net/ipn3ke/ipn3ke_tm.c b/drivers/net/ipn3ke/ipn3ke_tm.c
> index a93145d59..5a16c5f96 100644
> --- a/drivers/net/ipn3ke/ipn3ke_tm.c
> +++ b/drivers/net/ipn3ke/ipn3ke_tm.c
> @@ -1088,5 +1088,4 @@ ipn3ke_tm_node_add_check_mount(uint32_t tm_id,
>         struct rte_tm_error *error)
>  {
> -       /*struct ipn3ke_tm_internals *tm = IPN3KE_DEV_PRIVATE_TO_TM(dev);*/
>         uint32_t node_index;
>         uint32_t parent_index;
> --
> 2.21.0
>

Reviewed-by: David Marchand <david.marchand at redhat.com>


-- 
David Marchand


More information about the dev mailing list