[dpdk-dev] [PATCH v3] net/i40e: Fail rte_flow MARK requests if RX func was vectorized

Ye Xiaolong xiaolong.ye at intel.com
Wed Oct 30 15:01:16 CET 2019


Latest update, since i40e now has added FDIR ID to vector rx after patchset
https://patches.dpdk.org/cover/60820/ being merged, this patch is no longer
needed, so just drop it from next-net-intel.

Thanks,
Xiaolong

On 10/28, Ye Xiaolong wrote:
>Sorry for missing this patch for a long time.
>
>On 06/03, Mesut Ali Ergin wrote:
>>Runtime requests to install an rte_flow with MARK action should fail
>>if the device was started and a vector RX function was already chosen
>>for during configuration time.
>>
>>Currently, i40e rte_flow driver would successfully install the flow
>>with MARK action, even when vector RX functions are in use. However,
>>those vector RX functions will fail to retrieve the MARK data from the
>>device descriptor into the mbuf. The original app installing the flow
>>would never know what went wrong. The function introduced in this patch
>>must be adjusted if/when certain vector RX functions start supporting
>>correct FDIR processing for MARK actions.
>>
>>Fixes: 2e67a7fbf3ff ("net/i40e: config flow director automatically")
>>Cc: stable at dpdk.org
>>
>>Signed-off-by: Mesut Ali Ergin <mesut.a.ergin at intel.com>
>>
>>v3:
>> - Check for support made in an function for future extensibility
>> - Fixes code style warnings
>> - CC stable w/ fix reference
>>v2:
>> - Check added to fail MARK request only if the device was started
>>---
>
>Minor nit, you should put the change logs after above '---' line, then they can be
>ignored when git-am, fix it while merging.
>
>> drivers/net/i40e/i40e_flow.c | 30 ++++++++++++++++++++++++++++++
>> 1 file changed, 30 insertions(+)
>
>Reviewed-by: Xiaolong Ye <xiaolong.ye at intel.com>
>
>Applied to dpdk-next-net-intel. Thanks.


More information about the dev mailing list