[dpdk-dev] [PATCH v5] net/ixgbe: fix macsec setting

Ye Xiaolong xiaolong.ye at intel.com
Thu Oct 31 03:12:26 CET 2019


On 10/30, Sun GuinanX wrote:
>macsec setting is not valid when port is stopped.
>In order to make it valid, the patch changes the setting
>to where port is started.
>
>Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
>Cc: stable at dpdk.org

[snip]

>
>+void
>+ixgbe_dev_macsec_register_enable(struct rte_eth_dev *dev,
>+				struct ixgbe_macsec_setting *macsec_contrl)
>+{
>+	struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
>+	uint32_t ctrl;
>+	uint8_t en = (uint8_t)macsec_contrl->encrypt_en;
>+	uint8_t rp = (uint8_t)macsec_contrl->replayprotect_en;

cast here is unnecessary, and contrl is not a valid word, prefer to use
macsec_setting instead.


Thanks,
Xiaolong


More information about the dev mailing list