[dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

Thomas Monjalon thomas at monjalon.net
Thu Oct 31 14:45:40 CET 2019


29/10/2019 17:53, Andrew Rybchenko:
> On 10/29/19 6:37 PM, pbhagavatula at marvell.com wrote:
> > From: Pavan Nikhilesh <pbhagavatula at marvell.com>
> > --- a/lib/librte_ethdev/rte_ethdev.c
> > +++ b/lib/librte_ethdev/rte_ethdev.c
> > +static int
> > +_rte_eth_dev_validate_offloads(uint16_t port_id, uint64_t req_offloads,
> 
> I'm not sure about underscore in function name. May be Thomas or
> Ferruh can comment.

If it is private, don't use the rte_ prefix at all.
This function can be simply named "validate_offloads".





More information about the dev mailing list