[dpdk-dev] [PATCH 10/11] drivers/net: use new logtype wrapper

Stephen Hemminger stephen at networkplumber.org
Tue Sep 3 17:03:25 CEST 2019


On Tue, 3 Sep 2019 10:06:30 +0200
David Marchand <david.marchand at redhat.com> wrote:

> On Mon, Sep 2, 2019 at 6:11 PM Ferruh Yigit <ferruh.yigit at intel.com> wrote:
> >
> > On 8/19/2019 12:41 PM, David Marchand wrote:  
> > > Make use of the newly introduced wrapper.
> > >
> > > Signed-off-by: David Marchand <david.marchand at redhat.com>  
> >
> > <...>
> >  
> > > diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c
> > > index 931e4f4..c71b68e 100644
> > > --- a/drivers/net/mlx4/mlx4.c
> > > +++ b/drivers/net/mlx4/mlx4.c
> > > @@ -1274,16 +1274,14 @@ glue_error:
> > >
> > >  #endif
> > >
> > > +RTE_LOG_REGISTER(mlx4_logtype, "pmd.net.mlx4",
> > > +     RTE_LOG_NOTICE, RTE_LOGTYPE_PMD);
> > > +  
> >
> > btw, compiler is complaining about the ';' for mlx4/5 because of the pedantic
> > parameter:
> >
> > error: ISO C does not allow extra ‘;’ outside of a function [-Werror=pedantic]
> >  
> 
> Oops, I thought I had fixed it before sending the series.. thanks.

Yeas, please remove ; after all RTE_LOG_REGISTER macro usage.


More information about the dev mailing list