[dpdk-dev] [PATCH 02/13] net/failsafe: check code of promiscuous mode switch

Andrew Rybchenko arybchenko at solarflare.com
Thu Sep 5 18:38:23 CEST 2019


On 9/5/19 7:36 PM, Stephen Hemminger wrote:
> On Thu, 5 Sep 2019 17:10:40 +0100
> Andrew Rybchenko <arybchenko at solarflare.com> wrote:
>
>> +		if (ret != 0) {
>> +			ERROR("Failed to apply promiscuous mode");
>> +			return ret;
>> +		}
> Just return the error as normal and let caller deal with it.
> Additional logging is not necessary.

In this particular case we simply follow style around.
No strong opinion. Up to Gaetan.



More information about the dev mailing list