[dpdk-dev] [PATCH 13/22] net/hns3: add support for mailbox of hns3 PMD driver

[Wei Hu (Xavier)]

Hi, Ferruh Yigit


On 2019/8/30 23:08, Ferruh Yigit wrote:
> On 8/23/2019 2:47 PM, Wei Hu (Xavier) wrote:
>> This patch adds support for mailbox of hns3 PMD driver, mailbox is
>> used for communication between PF and VF driver.
>>
>> Signed-off-by: Min Hu (Connor) <humin29 at huawei.com>
>> Signed-off-by: Wei Hu (Xavier) <xavier.huwei at huawei.com>
>> Signed-off-by: Chunsong Feng <fengchunsong at huawei.com>
>> Signed-off-by: Hao Chen <chenhao164 at huawei.com>
>> Signed-off-by: Huisong Li <lihuisong at huawei.com>
> <...>
>
>> @@ -27,6 +27,7 @@
>>  #include <rte_io.h>
>>  
>>  #include "hns3_cmd.h"
>> +#include "hns3_mbx.h"
> Why need to include the new header if .c file is not using from the header? Same
> for other .c files below.
We will fix it in patch V2.
> <...>
>
>> @@ -0,0 +1,337 @@
>> +/* SPDX-License-Identifier: BSD-3-Clause
>> + * Copyright(c) 2018-2019 Hisilicon Limited.
>> + */
>> +
>> +#include <errno.h>
>> +#include <stdbool.h>
>> +#include <stdint.h>
>> +#include <stdio.h>
>> +#include <stdlib.h>
>> +#include <string.h>
>> +#include <sys/queue.h>
>> +#include <inttypes.h>
>> +#include <unistd.h>
>> +#include <rte_byteorder.h>
>> +#include <rte_common.h>
>> +#include <rte_cycles.h>
>> +#include <rte_debug.h>
>> +#include <rte_dev.h>
>> +#include <rte_eal.h>
>> +#include <rte_ether.h>
>> +#include <rte_ethdev_driver.h>
>> +#include <rte_io.h>
>> +#include <rte_spinlock.h>
>> +#include <rte_pci.h>
>> +#include <rte_bus_pci.h>
> Same comment for all .c files in the driver, above inclusion list feels like a
> copy/paste, can you please include only necessary headers?
>
    We will fix it in patch V2.
    Thanks for your suggestion.

    Regards
Xavier

    Regards
Xavier