[dpdk-dev] [PATCH] bus/fslmc: fix for resource leak coverity issue

[Babu Radhakrishnan, AgalyaX]

Hi,

> -----Original Message-----
> From: Babu Radhakrishnan, AgalyaX
> Sent: Tuesday, September 10, 2019 1:01 PM
> To: dev at dpdk.org
> Cc: Pattan, Reshma <reshma.pattan at intel.com>;
> hemant.agrawal at nxp.com; sachin.saxena at nxp.com; Parthasarathy,
> JananeeX M <jananeex.m.parthasarathy at intel.com>; Babu Radhakrishnan,
> AgalyaX <agalyax.babu.radhakrishnan at intel.com>; stable at dpdk.org
> Subject: [PATCH] bus/fslmc: fix for resource leak coverity issue
> 
> From: Agalya Babu RadhaKrishnan <agalyax.babu.radhakrishnan at intel.com>
> 
> 1 issue caught by 344967
> Leaked_storage: Variable sep going out of scope leaks the storage it points
> to.
> 
> When 'sep' is not null and sep_exist is 0, 'sep' is freed before going out of
> scope of the function irrespective of 'addr' exists or not.
> 
> Coverity Issue: 344967
> Fixes: e67a61614d0b ("bus/fslmc: support device iteration")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Agalya Babu RadhaKrishnan
> <agalyax.babu.radhakrishnan at intel.com>
> ---

if (strncmp("dpni", sep, 4) &&
            strncmp("dpseci", sep, 6) &&
            strncmp("dpcon", sep, 5) &
            .....

We think validation of device name is done using AND operator instead it should be done by OR operator.
Please confirm.