[dpdk-dev] net/e1000: fix wrong mac type checking

Kevin Traynor ktraynor at redhat.com
Tue Sep 10 11:17:18 CEST 2019


On 10/09/2019 18:40, Xiao Zhang wrote:
> The mac types of i219 are e1000_pch_spt and e1000_pch_cnp, correct the
> checking code of mac type when flushing i219 descriptor rings.
> 
> Fixes: 1fc9701238ed ("net/e1000: fix i219 hang on reset/close")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Xiao Zhang <xiao.zhang at intel.com>
Reported-by: Kevin Traynor <ktraynor at redhat.com>
Acked-by: Kevin Traynor <ktraynor at redhat.com>

> ---
>  drivers/net/e1000/em_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c
> index 20b5406..fd44924 100644
> --- a/drivers/net/e1000/em_ethdev.c
> +++ b/drivers/net/e1000/em_ethdev.c
> @@ -739,7 +739,7 @@ eth_em_stop(struct rte_eth_dev *dev)
>  	e1000_reset_hw(hw);
>  
>  	/* Flush desc rings for i219 */
> -	if (hw->mac.type >= e1000_pch_spt)
> +	if (hw->mac.type == e1000_pch_spt || hw->mac.type == e1000_pch_cnp)
>  		em_flush_desc_rings(dev);
>  
>  	if (hw->mac.type >= e1000_82544)
> 



More information about the dev mailing list