[dpdk-dev] [PATCH 22/22] net/hns3: add hns3 build files

[Wei Hu (Xavier)]

Hi, Ferruh Yigit


On 2019/8/30 22:58, Ferruh Yigit wrote:
> On 8/23/2019 2:47 PM, Wei Hu (Xavier) wrote:
>> This patch add build related files for hns3 PMD driver.
>>
>> Signed-off-by: Wei Hu (Xavier) <xavier.huwei at huawei.com>
>> Signed-off-by: Min Hu (Connor) <humin29 at huawei.com>
>> Signed-off-by: Chunsong Feng <fengchunsong at huawei.com>
>> Signed-off-by: Hao Chen <chenhao164 at huawei.com>
>> Signed-off-by: Huisong Li <lihuisong at huawei.com>
>> ---
>>  MAINTAINERS                                  |  7 ++++
>>  config/common_armv8a_linux                   |  5 +++
>>  config/common_base                           |  5 +++
>>  config/defconfig_arm64-armv8a-linuxapp-clang |  2 +
>>  doc/guides/nics/features/hns3.ini            | 38 +++++++++++++++++++
>>  doc/guides/nics/hns3.rst                     | 55 ++++++++++++++++++++++++++++
> This file needs to be added to the index file: 'doc/guides/nics/index.rst'
Thanks for your suggestion.
We will fix it in patch V2.
>
> <...>
>
>> diff --git a/config/defconfig_arm64-armv8a-linuxapp-clang b/config/defconfig_arm64-armv8a-linuxapp-clang
>> index d3b4dad..c73f5fb 100644
>> --- a/config/defconfig_arm64-armv8a-linuxapp-clang
>> +++ b/config/defconfig_arm64-armv8a-linuxapp-clang
>> @@ -6,3 +6,5 @@
>>  
>>  CONFIG_RTE_TOOLCHAIN="clang"
>>  CONFIG_RTE_TOOLCHAIN_CLANG=y
>> +
>> +CONFIG_RTE_LIBRTE_HNS3_PMD=n
> I can understand the architecture ones, but why clang is not supported? Can you
> please add this support?
We will fix it in patch V2.
> <...>
>
>> diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.rst
>> new file mode 100644
>> index 0000000..c9d0253
>> --- /dev/null
>> +++ b/doc/guides/nics/hns3.rst
>> @@ -0,0 +1,55 @@
>> +..  SPDX-License-Identifier: BSD-3-Clause
>> +    Copyright(c) 2018-2019 Hisilicon Limited.
>> +
>> +HNS3 Poll Mode Driver
>> +===============================
>> +
>> +The Hisilicon Network Subsystem is a long term evolution IP which is
>> +supposed to be used in Hisilicon ICT SoCs such as Kunpeng 920.
> Can you please add a official link/reference to the product?
>

The official website link of kunpeng920 chip is not available yet,
And we will paste the link to the servers product using kunpeng920 in
patch V2.
Thanks for your suggestion.

> <...>
>
>> @@ -0,0 +1,43 @@
>> +# SPDX-License-Identifier: BSD-3-Clause
>> +# Copyright(c) 2018-2019 Hisilicon Limited.
>> +
>> +include $(RTE_SDK)/mk/rte.vars.mk
>> +
>> +#
>> +# library name
>> +#
>> +LIB = librte_pmd_hns3.a
>> +
>> +CFLAGS += -O3
>> +CFLAGS += $(WERROR_FLAGS)
>> +CFLAGS += -DALLOW_EXPERIMENTAL_API -fsigned-char
> Why '-DALLOW_EXPERIMENTAL_API' is required? Can we remove it?
There are some APIs as follows in hns3 PMD driver, 
'-DALLOW_EXPERIMENTAL_API'  can clear warning during compiling.
# Experimantal APIs:
# - rte_mp_action_register
# - rte_mp_action_unregister
# - rte_mp_reply
# - rte_mp_request_sync
>> +
>> +LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
>> +LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs -lrte_hash
>> +LDLIBS += -lrte_bus_pci
> Are all these libraries really required, like kvargs? Can you please clean the
> unused ones?
We will fix it in patch V2.
>> +
>> +EXPORT_MAP := rte_pmd_hns3_version.map
>> +
>> +LIBABIVER := 2
> It should be 1.
We will fix it in patch V2.
>
> <...>
>
>> +# install this header file
>> +SYMLINK-$(CONFIG_RTE_LIBRTE_HNS3_PMD)-include := hns3_ethdev.h
> No need to expose the header file, it is not public header.
We will fix it in patch V2.
>
> <...>
>
>> @@ -0,0 +1,19 @@
>> +# SPDX-License-Identifier: BSD-3-Clause
>> +# Copyright(c) 2018-2019 Hisilicon Limited
>> +
>> +sources = files('hns3_cmd.c',
>> +	'hns3_dcb.c',
>> +	'hns3_intr.c',
>> +	'hns3_ethdev.c',
>> +	'hns3_ethdev_vf.c',
>> +	'hns3_fdir.c',
>> +	'hns3_flow.c',
>> +	'hns3_mbx.c',
>> +	'hns3_regs.c',
>> +	'hns3_rss.c',
>> +	'hns3_rxtx.c',
>> +	'hns3_stats.c',
>> +	'hns3_mp.c')
>> +deps += ['hash']
>> +
>> +cflags += '-DALLOW_EXPERIMENTAL_API'
> There is better way to do this in meson, please check other samples. But as the
> makefile comment, does it really needed, if so can you please add the
> experimental APIs used as a comment, to both meson and Makefile?
I will update it as follows:

allow_experimental_apis = true
# Experimantal APIs:
# - rte_mp_action_register
# - rte_mp_action_unregister
# - rte_mp_reply
# - rte_mp_request_sync

Thanks for your suggestion.

>> diff --git a/drivers/net/hns3/rte_pmd_hns3_version.map b/drivers/net/hns3/rte_pmd_hns3_version.map
>> new file mode 100644
>> index 0000000..3aef967
>> --- /dev/null
>> +++ b/drivers/net/hns3/rte_pmd_hns3_version.map
>> @@ -0,0 +1,3 @@
>> +DPDK_19.08 {
> DPDK_19.11
We will fix it in patch V2.



   Thanks for your suggestion.

   Regards
Xavier
>
> .
>