[dpdk-dev] [PATCH v2] net/mlx5: fix netlink rdma socket callback routine

Raslan Darawsheh rasland at mellanox.com
Tue Sep 10 16:28:05 CEST 2019


Hi,

> -----Original Message-----
> From: Viacheslav Ovsiienko <viacheslavo at mellanox.com>
> Sent: Tuesday, September 10, 2019 4:52 PM
> To: dev at dpdk.org
> Cc: Raslan Darawsheh <rasland at mellanox.com>; stable at dpdk.org
> Subject: [PATCH v2] net/mlx5: fix netlink rdma socket callback routine
> 
> The mlx5 PMD uses Netlink socket to communicate with Infiniband
> devices kernel drivers to perform some control and setup operations.
> The kernel drivers send the information back to the user mode
> with Netlink messages which are processed in libnl callback routine.
> This routine perform reply message (or set of messages) processing
> and returned the processing result in ibindex field of provided
> context structure (of mlx5_nl_ifindex_data type). The zero ibindex
> value meant an error of reply message processing. It was found in
> some configurations the zero is valid value for ibindex and error
> was wrongly raised. To avoid this the new flags field is provided
> in context structure, attribute processing flags are introduced
> and these flags are used to decide whether no error occurred and
> valid queried values are returned.
> 
> Fixes: e505508a3858 ("net/mlx5: modify get ifindex routine for multiport IB")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo at mellanox.com>
> ---
> v2: reverted back local parameter gathering within one Netlink message
>     in callback routine. It allows to avoid parameters overwriting in
>     case of reply contains multiple messages for all Infiniband devices
>     in the system.
> 
> v1:
> https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch
> es.dpdk.org%2Fpatch%2F59057%2F&data=02%7C01%7Crasland%40mell
> anox.com%7C8e8cc6e9af8a4552ba8e08d735f60c17%7Ca652971c7d2e4d9ba6a
> 4d149256f461b%7C0%7C0%7C637037203199776325&sdata=E4XI4EG%2B
> ri7OuNiWGWOtA1vZL31LYvVOPUpsiR%2Bz2p8%3D&reserved=0
> 

Replaced V1 with V2 due to some issue was in V1,

So applied v2 to next-net-mlx,

Kindest regards,
Raslan Darawsheh


More information about the dev mailing list