[dpdk-dev] [PATCH v2 1/3] test/rcu: fix the compiling error for armv8.2

Jerin Jacob Kollanukkaran jerinj at marvell.com
Wed Sep 11 12:38:03 CEST 2019



> -----Original Message-----
> From: Gavin Hu <gavin.hu at arm.com>
> Sent: Thursday, August 1, 2019 5:18 AM
> To: dev at dpdk.org
> Cc: nd at arm.com; thomas at monjalon.net; hemant.agrawal at nxp.com; Jerin
> Jacob Kollanukkaran <jerinj at marvell.com>; Pavan Nikhilesh Bhagavatula
> <pbhagavatula at marvell.com>; Honnappa.Nagarahalli at arm.com;
> stable at dpdk.org
> Subject: [EXT] [PATCH v2 1/3] test/rcu: fix the compiling error for armv8.2
> 
> With "-march=armv8.2-a" specified, a compiling error generated:
> app/test/test_rcu_qsbr.c:234:10: error: comparison of integer expressions of
> different signedness: ‘unsigned int’ and ‘int’
> [-Werror=sign-compare]
> 
> Fixes: b87089b0bb19 ("test/rcu: add API and functional tests")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Gavin Hu <gavin.hu at arm.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli at arm.com>
> Reviewed-by: Steve Capper <steve.capper at arm.com>


Reviewed-by: Jerin Jacob <jerinj at marvell.com>


> ---
>  app/test/test_rcu_qsbr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test/test_rcu_qsbr.c b/app/test/test_rcu_qsbr.c index
> 1d273e3..b008c9d 100644
> --- a/app/test/test_rcu_qsbr.c
> +++ b/app/test/test_rcu_qsbr.c
> @@ -231,7 +231,7 @@ test_rcu_qsbr_thread_unregister(void)
>  		/* Update quiescent state counter */
>  		for (i = 0; i < num_threads[j]; i++) {
>  			/* Skip one update */
> -			if (i == (RTE_MAX_LCORE - 10))
> +			if (i == (unsigned int)(RTE_MAX_LCORE - 10))
>  				continue;
>  			rte_rcu_qsbr_quiescent(t[0],
>  				(j == 2) ? (RTE_MAX_LCORE - 1) : i);
> --
> 2.7.4



More information about the dev mailing list