[dpdk-dev] [PATCH v4 02/54] ethdev: change rte_eth_dev_info_get() return value to int

[Andrew Rybchenko]

Hi Bernard,

On 9/13/19 1:18 PM, Iremonger, Bernard wrote:
> Hi Ivan,
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Andrew Rybchenko
>> Sent: Thursday, September 12, 2019 5:42 PM
>> To: Neil Horman <nhorman at tuxdriver.com>; Mcnamara, John
>> <john.mcnamara at intel.com>; Kovacevic, Marko
>> <marko.kovacevic at intel.com>; Thomas Monjalon <thomas at monjalon.net>;
>> Yigit, Ferruh <ferruh.yigit at intel.com>
>> Cc: dev at dpdk.org; Ivan Ilchenko <Ivan.Ilchenko at oktetlabs.com>
>> Subject: [dpdk-dev] [PATCH v4 02/54] ethdev: change
>> rte_eth_dev_info_get() return value to int
>>
>> From: Ivan Ilchenko <Ivan.Ilchenko at oktetlabs.com>
>>
>> Change rte_eth_dev_info_get() return value from void to int and return
>> negative errno values in case of error conditions.
>> Modify rte_eth_dev_info_get() usage across the ethdev according to new
>> return type.
>>
>> Signed-off-by: Ivan Ilchenko <Ivan.Ilchenko at oktetlabs.com>
>> Signed-off-by: Andrew Rybchenko <arybchenko at solarflare.com>
>> Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>
> ./check-git-log.sh -1
> Wrong headline format:
>          ethdev: change rte_eth_dev_info_get() return value to int

In this particular case we decided (may be incorrectly) that it would
be more harm if we rephrase it without mentioning function name.
It is trivial to fix. No strong opinion.

My main goal of yesterday re-spin was to check build with missing
patch applied to DPDK main repo, but unfortunately there are still
some build issues (meson column) which I don't understand.

Andrew.