[dpdk-dev] [PATCH 6/9] eal: getopt implementation for windows

Pallavi Kadam pallavi.kadam at intel.com
Fri Sep 13 19:23:51 CEST 2019


Hi Stephen

On 9/13/2019 2:46 AM, Bruce Richardson wrote:
> On Thu, Sep 12, 2019 at 11:40:43PM +0200, Stephen Hemminger wrote:
>> On Mon,  9 Sep 2019 12:54:01 -0700
>> Pallavi Kadam <pallavi.kadam at intel.com> wrote:
>>
>>> Adding getopt_long.c and getopt.c files to support parsing
>>> option on Windows.
>>> The original contribution is under MIT license.
>>>
>>> Signed-off-by: Antara Ganesh Kolar <antara.ganesh.kolar at intel.com>
>>> Signed-off-by: Pallavi Kadam <pallavi.kadam at intel.com>
>>> Reviewed-by: Ranjit Menon <ranjit.menon at intel.com>
>>> Reviewed-by: Keith Wiles <keith.wiles at intel.com>
>> \ )
>>
>> Is this the same as BSD?
>>
>> https://github.com/freebsd/freebsd/blob/master/lib/libc/stdlib/getopt_long.c
> I'm not sure it matters even if it is. That code is not under a
> BSD-3-Clause license either, so still would require the same exceptions.
>
> /Bruce

I don't think these are the same files.

We tried one similar BSD-2-Clause implementation which also builds 
cleanly on Windows.

So, between BSD-2 and MIT License we decided to opt for MIT License 
implementation.

As Bruce mentioned, BSD-2-CLasue implementation is also not acceptable, 
am I correct?



More information about the dev mailing list