[dpdk-dev] [PATCH v3] net/vmxnet3: Added mtu_set() function to allow setting MTU.

Ferruh Yigit ferruh.yigit at intel.com
Fri Sep 13 20:59:25 CEST 2019


On 9/13/2019 7:47 PM, Ferruh Yigit wrote:
> On 8/21/2019 3:16 AM, Myers, Charles wrote:
>> From: Charles Myers <charles.myers at spirent.com>
>>
>> When the mtu_set() function is not implemented, rte_eth_dev_set_mtu()
>> fails with -ENOTSUP and mtu is not stored in the mtu field in the
>> rte_eth_dev_data.  This causes the mtu in Vmxnet3_MiscConf which is
>> shared with hypervisor to always be set to 1500.
>>
>> This may cause issues receiving jumbo frames on Enhanced Data Path
>> N-VDS.
>>
>> Signed-off-by: Charles Myers <charles.myers at spirent.com>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>
> 
> Applied to dpdk-next-net/master, thanks.

It seems there is waiting change request from the maintainer that I missed,
dropping the patch from the tree and updating the patchwork state.

Charles, can you please sync with Yong if the change request is not clear?

> 
> 
>> @@ -1205,6 +1209,18 @@ vmxnet3_dev_supported_ptypes_get(struct rte_eth_dev *dev)
>>  }
>>  
>>  static int
>> +vmxnet3_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
>> +{
> 
> 'mtu' is unused and giving build error:
> error: unused parameter ‘mtu’ [-Werror=unused-parameter]
> 
> Fixed while merging:
>  +vmxnet3_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu __rte_unused)
> 
> 



More information about the dev mailing list