[dpdk-dev] [PATCH v4 01/11] crypto/nitrox: add Nitrox build and doc skeleton

Akhil Goyal akhil.goyal at nxp.com
Fri Sep 20 11:02:13 CEST 2019



> -----Original Message-----
> From: Akhil Goyal
> Sent: Friday, September 20, 2019 2:26 PM
> To: 'Nagadheeraj Rottela' <rnagadheeraj at marvell.com>;
> pablo.de.lara.guarch at intel.com; mattias.ronnblom at ericsson.com
> Cc: dev at dpdk.org; Srikanth Jampala <jsrikanth at marvell.com>
> Subject: RE: [PATCH v4 01/11] crypto/nitrox: add Nitrox build and doc skeleton
> 
> 
> >
> > Add bare minimum Nitrox PMD library and doc build infrastructure and
> > claim responsibility by updating the maintainers file.
> >
> > Signed-off-by: Nagadheeraj Rottela <rnagadheeraj at marvell.com>
> > ---
> 
> > diff --git a/drivers/crypto/nitrox/nitrox_device.c
> > b/drivers/crypto/nitrox/nitrox_device.c
> > new file mode 100644
> > index 000000000..d26535dee
> > --- /dev/null
> > +++ b/drivers/crypto/nitrox/nitrox_device.c
> > @@ -0,0 +1,3 @@
> > +/* SPDX-License-Identifier: BSD-3-Clause
> > + * Copyright(C) 2019 Marvell International Ltd.
> > + */
> 
> Adding an empty file is not a good idea.
> I believe you can squash your 1/11,2/11,3/11 patches together. These are
> initializing the driver.
> 
3/11 can be a separate patch, but 1 -2 should be merged.



More information about the dev mailing list