[dpdk-dev] [PATCH v2 0/4] net/bnx2x: update to latest FW

[Ferruh Yigit]

On 9/19/2019 10:11 PM, Rasesh Mody wrote:
> Hi,
> 
> Currently, BNX2X PMD uses a very old firmware 7.2.51.
> This patch series updated the base driver to use to latest
> firmware 7.13.11. The latest firmware comprises of enhancements
> and fixes.
> 
> v2:
>  - Squashed pmd version patch into "net/bnx2x: update to latest FW 7.13.11"
>  - Addressed most of checkpatch issues
> 
> Thanks!
> -Rasesh
> 
> Rasesh Mody (4):
>   net/bnx2x: update and reorganize HW registers
>   net/bnx2x: update HSI code
>   net/bnx2x: update to latest FW 7.13.11
>   doc: cleanup SPDX license id usage in bnx2x guide
> 

I am getting build errors with this patchset [1], since it is merged into
next-net-mrvl, I only pulled the doc patch, 4/4, but not others, can you please
check the patchset?




[1]
In file included from .../dpdk/drivers/net/bnx2x/bnx2x.h:22,
                 from .../dpdk/drivers/net/bnx2x/bnx2x_rxtx.c:8:
.../dpdk/drivers/net/bnx2x/bnx2x_osal.h:25:17: error: conflicting types for
‘uint64_t’
   25 | #define __le64  uint64_t
      |                 ^~~~~~~~
In file included from /usr/include/stdint.h:37,
                 from /usr/lib/gcc/x86_64-redhat-linux/9/include/stdint.h:9,
                 from
.../dpdk/x86_64-native-linuxapp-gcc/include/rte_byteorder.h:12,
                 from .../dpdk/drivers/net/bnx2x/bnx2x.h:17,
                 from .../dpdk/drivers/net/bnx2x/bnx2x_rxtx.c:8:
/usr/include/bits/stdint-uintn.h:27:20: note: previous declaration of ‘uint64_t’
was here
   27 | typedef __uint64_t uint64_t;
      |                    ^~~~~~~~
In file included from .../dpdk/drivers/net/bnx2x/bnx2x_ethdev.h:33,
                 from .../dpdk/drivers/net/bnx2x/bnx2x.h:23,
                 from .../dpdk/drivers/net/bnx2x/bnx2x_rxtx.c:8:
.../dpdk/x86_64-native-linuxapp-gcc/include/rte_ethdev_driver.h: In function
‘rte_eth_linkstatus_set’:
.../dpdk/x86_64-native-linuxapp-gcc/include/rte_ethdev_driver.h:176:37: error:
passing argument 1 of ‘rte_atomic64_exchange’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
  176 |  orig.val64 = rte_atomic64_exchange(dev_link,
      |                                     ^~~~~~~~
      |                                     |
      |                                     volatile uint64_t * {aka volatile
long long unsigned int *}
In file included from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_atomic.h:263,
                 from
.../dpdk/x86_64-native-linuxapp-gcc/include/generic/rte_cycles.h:18,
                 from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_cycles.h:13,
                 from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_spinlock.h:18,
                 from .../dpdk/drivers/net/bnx2x/bnx2x.h:18,
                 from .../dpdk/drivers/net/bnx2x/bnx2x_rxtx.c:8:
.../dpdk/x86_64-native-linuxapp-gcc/include/rte_atomic_64.h:48:42: note:
expected ‘volatile uint64_t *’ {aka ‘volatile long unsigned int *’} but argument
is of type ‘volatile uint64_t *’ {aka ‘volatile long long unsigned int *’}
   48 | rte_atomic64_exchange(volatile uint64_t *dst, uint64_t val)
      |                       ~~~~~~~~~~~~~~~~~~~^~~
cc1: all warnings being treated as errors




In file included from .../dpdk/drivers/net/bnx2x/bnx2x.h:22,
                 from .../dpdk/drivers/net/bnx2x/bnx2x_vfpf.c:8:
.../dpdk/drivers/net/bnx2x/bnx2x_osal.h:25:17: error: conflicting types for
‘uint64_t’
   25 | #define __le64  uint64_t
      |                 ^~~~~~~~
In file included from /usr/include/stdint.h:37,
                 from /usr/lib/gcc/x86_64-redhat-linux/9/include/stdint.h:9,
                 from
.../dpdk/x86_64-native-linuxapp-gcc/include/rte_byteorder.h:12,
                 from .../dpdk/drivers/net/bnx2x/bnx2x.h:17,
                 from .../dpdk/drivers/net/bnx2x/bnx2x_vfpf.c:8:
/usr/include/bits/stdint-uintn.h:27:20: note: previous declaration of ‘uint64_t’
was here
   27 | typedef __uint64_t uint64_t;
      |                    ^~~~~~~~
In file included from .../dpdk/drivers/net/bnx2x/bnx2x_ethdev.h:33,
                 from .../dpdk/drivers/net/bnx2x/bnx2x.h:23,
                 from .../dpdk/drivers/net/bnx2x/bnx2x_vfpf.c:8:
.../dpdk/x86_64-native-linuxapp-gcc/include/rte_ethdev_driver.h: In function
‘rte_eth_linkstatus_set’:
.../dpdk/x86_64-native-linuxapp-gcc/include/rte_ethdev_driver.h:176:37: error:
passing argument 1 of ‘rte_atomic64_exchange’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
  176 |  orig.val64 = rte_atomic64_exchange(dev_link,
      |                                     ^~~~~~~~
      |                                     |
      |                                     volatile uint64_t * {aka volatile
long long unsigned int *}
In file included from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_atomic.h:263,
                 from
.../dpdk/x86_64-native-linuxapp-gcc/include/generic/rte_cycles.h:18,
                 from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_cycles.h:13,
                 from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_spinlock.h:18,
                 from .../dpdk/drivers/net/bnx2x/bnx2x.h:18,
                 from .../dpdk/drivers/net/bnx2x/bnx2x_vfpf.c:8:
.../dpdk/x86_64-native-linuxapp-gcc/include/rte_atomic_64.h:48:42: note:
expected ‘volatile uint64_t *’ {aka ‘volatile long unsigned int *’} but argument
is of type ‘volatile uint64_t *’ {aka ‘volatile long long unsigned int *’}
   48 | rte_atomic64_exchange(volatile uint64_t *dst, uint64_t val)
      |                       ~~~~~~~~~~~~~~~~~~~^~~
cc1: all warnings being treated as errors


make[7]: *** [.../dpdk/mk/internal/rte.compile-pre.mk:116: ecore_sp.o] Error 1
In file included from .../dpdk/drivers/net/bnx2x/bnx2x.h:22,
                 from .../dpdk/drivers/net/bnx2x/bnx2x_ethdev.c:8:
.../dpdk/drivers/net/bnx2x/bnx2x_osal.h:25:17: error: conflicting types for
‘uint64_t’
   25 | #define __le64  uint64_t
      |                 ^~~~~~~~
In file included from /usr/include/stdint.h:37,
                 from /usr/lib/gcc/x86_64-redhat-linux/9/include/stdint.h:9,
                 from
.../dpdk/x86_64-native-linuxapp-gcc/include/rte_byteorder.h:12,
                 from .../dpdk/drivers/net/bnx2x/bnx2x.h:17,
                 from .../dpdk/drivers/net/bnx2x/bnx2x_ethdev.c:8:
/usr/include/bits/stdint-uintn.h:27:20: note: previous declaration of ‘uint64_t’
was here
   27 | typedef __uint64_t uint64_t;
      |                    ^~~~~~~~
In file included from .../dpdk/drivers/net/bnx2x/bnx2x_ethdev.h:33,
                 from .../dpdk/drivers/net/bnx2x/bnx2x.h:23,
                 from .../dpdk/drivers/net/bnx2x/bnx2x_ethdev.c:8:
.../dpdk/x86_64-native-linuxapp-gcc/include/rte_ethdev_driver.h: In function
‘rte_eth_linkstatus_set’:
.../dpdk/x86_64-native-linuxapp-gcc/include/rte_ethdev_driver.h:176:37: error:
passing argument 1 of ‘rte_atomic64_exchange’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
  176 |  orig.val64 = rte_atomic64_exchange(dev_link,
      |                                     ^~~~~~~~
      |                                     |
      |                                     volatile uint64_t * {aka volatile
long long unsigned int *}
In file included from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_atomic.h:263,
                 from
.../dpdk/x86_64-native-linuxapp-gcc/include/generic/rte_cycles.h:18,
                 from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_cycles.h:13,
                 from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_spinlock.h:18,
                 from .../dpdk/drivers/net/bnx2x/bnx2x.h:18,
                 from .../dpdk/drivers/net/bnx2x/bnx2x_ethdev.c:8:
.../dpdk/x86_64-native-linuxapp-gcc/include/rte_atomic_64.h:48:42: note:
expected ‘volatile uint64_t *’ {aka ‘volatile long unsigned int *’} but argument
is of type ‘volatile uint64_t *’ {aka ‘volatile long long unsigned int *’}
   48 | rte_atomic64_exchange(volatile uint64_t *dst, uint64_t val)
      |                       ~~~~~~~~~~~~~~~~~~~^~~
cc1: all warnings being treated as errors


In file included from .../dpdk/drivers/net/bnx2x/bnx2x_ethdev.h:40,
                 from .../dpdk/drivers/net/bnx2x/bnx2x.h:23,
                 from .../dpdk/drivers/net/bnx2x/bnx2x.c:16:
.../dpdk/drivers/net/bnx2x/bnx2x.c: In function ‘bnx2x_dma_alloc’:
.../dpdk/drivers/net/bnx2x/bnx2x_logs.h:21:3: error: format ‘%lx’ expects
argument of type ‘long unsigned int’, but argument 9 has type ‘rte_iova_t’ {aka
‘long long unsigned int’} [-Werror=format=]
   21 |   "[%s:%d(%s)] " fmt, __func__, __LINE__, \
      |   ^~~~~~~~~~~~~~
.../dpdk/drivers/net/bnx2x/bnx2x_logs.h:25:2: note: in expansion of macro
‘PMD_DRV_LOG_RAW’
   25 |  PMD_DRV_LOG_RAW(level, sc, fmt "\n", ## args)
      |  ^~~~~~~~~~~~~~~
.../dpdk/drivers/net/bnx2x/bnx2x.c:190:2: note: in expansion of macro ‘PMD_DRV_LOG’
  190 |  PMD_DRV_LOG(DEBUG, sc,
      |  ^~~~~~~~~~~
In file included from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_bus_pci.h:25,
                 from .../dpdk/drivers/net/bnx2x/bnx2x.h:19,
                 from .../dpdk/drivers/net/bnx2x/bnx2x.c:16:
/usr/include/inttypes.h:121:34: note: format string is defined here
  121 | # define PRIx64  __PRI64_PREFIX "x"
In file included from .../dpdk/drivers/net/bnx2x/bnx2x_ethdev.h:40,
                 from .../dpdk/drivers/net/bnx2x/bnx2x.h:23,
                 from .../dpdk/drivers/net/bnx2x/bnx2x.c:16:
.../dpdk/drivers/net/bnx2x/bnx2x.c: In function ‘bnx2x_load_firmware’:
.../dpdk/drivers/net/bnx2x/bnx2x_logs.h:21:3: error: format ‘%lu’ expects
argument of type ‘long unsigned int’, but argument 7 has type ‘uint64_t’ {aka
‘long long unsigned int’} [-Werror=format=]
   21 |   "[%s:%d(%s)] " fmt, __func__, __LINE__, \
      |   ^~~~~~~~~~~~~~
.../dpdk/drivers/net/bnx2x/bnx2x_logs.h:25:2: note: in expansion of macro
‘PMD_DRV_LOG_RAW’
   25 |  PMD_DRV_LOG_RAW(level, sc, fmt "\n", ## args)
      |  ^~~~~~~~~~~~~~~
.../dpdk/drivers/net/bnx2x/bnx2x.c:9672:3: note: in expansion of macro ‘PMD_DRV_LOG’
 9672 |   PMD_DRV_LOG(NOTICE, sc,
      |   ^~~~~~~~~~~