[dpdk-dev] [PATCH] vhost: add __rte_experimental to rte_vhost_va_from_guest_pa

[Harris, James R]

On 9/23/19, 8:41 AM, "Yigit, Ferruh" <ferruh.yigit at intel.com> wrote:

    On 9/18/2019 2:12 PM, Maxime Coquelin wrote:
    > 
    > 
    > On 8/20/19 11:37 AM, Jim Harris wrote:
    >> This function is listed under EXPERIMENTAL in the
    >> rte_vhost_version.map, so it needs to be marked
    >> with __rte_experimental in the header file as well.
    >>
    >> Found by check-experimental-syms.sh when trying to compile
    >> DPDK with -finstrument-functions.  This script didn't
    >> catch this in the normal case, since the function is
    >> declared __rte_always_inline.
    >>
    >> Signed-off-by: Jim Harris <james.r.harris at intel.com>
    >> ---
    >>  lib/librte_vhost/rte_vhost.h |    1 +
    >>  1 file changed, 1 insertion(+)
    >>
    >> diff --git a/lib/librte_vhost/rte_vhost.h b/lib/librte_vhost/rte_vhost.h
    >> index 7fb172912..fc27bc21e 100644
    >> --- a/lib/librte_vhost/rte_vhost.h
    >> +++ b/lib/librte_vhost/rte_vhost.h
    >> @@ -225,6 +225,7 @@ rte_vhost_gpa_to_vva(struct rte_vhost_memory *mem, uint64_t gpa)
    >>   * @return
    >>   *  the host virtual address on success, 0 on failure
    >>   */
    >> +__rte_experimental
    >>  static __rte_always_inline uint64_t
    >>  rte_vhost_va_from_guest_pa(struct rte_vhost_memory *mem,
    >>  						   uint64_t gpa, uint64_t *len)
    >>
    > 
    > Fixed commit message to comply with check-git-log tool.
    > 
    > Applied to dpdk-next-virtio/master.
    
    This is breaking the 'vhost_scsi' sample application since it is using this
    experimental API [1].
    Build system should be updated to say sample application is allowed to using
    experimental APIs.
    Can you please send a new version?

Thanks Ferruh.  I missed that.  Does this mean adding the following to examples/vhost_scsi/Makefile?
    
CFLAGS += -DALLOW_EXPERIMENTAL_API

And this to examples/vhost_scsi/meson.build?

allow_experimental_apis = true

Maxime - please let me know if you need a patch from me that you'll apply to dpdk-next-virtio/master, or if you would send such a patch yourself.

Thanks,

-Jim