[dpdk-dev] [PATCH 00/18] ethdev: change link status get functions return value to int
Ferruh Yigit
ferruh.yigit at intel.com
Tue Sep 24 14:38:24 CEST 2019
On 9/10/2019 9:25 AM, Andrew Rybchenko wrote:
> It is the fifth patch series to get rid of void returning functions
> in ethdev in accordance with deprecation notice [1].
>
> It should be applied on top of [2], [3], [4] and [5].
>
> Functions which return void are bad since they do not provide explicit
> information to the caller if everything is OK or not.
>
> In the case of link info get it is important to know if link info is
> filled in or not.
>
> Unlike previous patch series for other functions, this one does not
> touch link_update driver callback since it already has return value
> with different semantics (which is not used in fact). May be negative
> return values should be kept for errors and positive 1 should report
> no link status changes. That's why only negative values are treated
> as errors in the patch series.
>
> [1] https://patches.dpdk.org/patch/56969/
> [2] https://patches.dpdk.org/project/dpdk/list/?series=6279
> [3] https://patches.dpdk.org/project/dpdk/list/?series=6334
> [4] https://patches.dpdk.org/project/dpdk/list/?series=6335
> [5] https://patches.dpdk.org/project/dpdk/list/?series=6308
>
> Andrew Rybchenko (2):
> net/memif: check status of getting link info
> app/pipeline: check status of getting link info
>
> Igor Romanov (16):
> net/bonding: fix link speed update in broadcast mode
> ethdev: change link status get functions return value to int
> app/testpmd: check status of getting link info
> net/bonding: check status of getting link info
> net/ixgbe: check status of getting link info
> app/proc-info: check status of getting link info
> app/test: check status of getting link info
> examples: check status of getting link info
> examples/bbdev_app: check status of getting link info
> examples/ip_pipeline: check status of getting link info
> examples/ethtool: check status of getting link info
> examples/flow_filtering: check status of getting link info
> examples/link_status_interrupt: check status of getting link
> examples/distributor: check status of getting link info
> examples/qos_sched: check status of getting link info
> examples/kni: check status of getting link info
Series applied to dpdk-next-net/master, thanks.
More information about the dev
mailing list