[dpdk-dev] [PATCH v3 1/8] net/ice: enable flow director engine

Cao, Yahui yahui.cao at intel.com
Wed Sep 25 08:37:20 CEST 2019


Thanks for the comments. Old version patches' states are changed.

-----Original Message-----
From: Gavin Hu (Arm Technology China) [mailto:Gavin.Hu at arm.com] 
Sent: Wednesday, September 25, 2019 11:20 AM
To: Cao, Yahui <yahui.cao at intel.com>; Yang, Qiming <qiming.yang at intel.com>; Lu, Wenzhuo <wenzhuo.lu at intel.com>
Cc: dev at dpdk.org; Zhang, Qi Z <qi.z.zhang at intel.com>; Ye, Xiaolong <xiaolong.ye at intel.com>; Xing, Beilei <beilei.xing at intel.com>; nd <nd at arm.com>
Subject: RE: [dpdk-dev] [PATCH v3 1/8] net/ice: enable flow director engine

Hi Yahui,

two general comments: 
1.Please make old versions of patches Superseded to facilitate review.
2. the two occurrences of rte_wmb can be removed, a similar patch has been reviewed by Qi. http://patches.dpdk.org/patch/59278/ 

/Gavin

> -----Original Message-----
> From: dev <dev-bounces at dpdk.org> On Behalf Of Yahui Cao
> Sent: Wednesday, September 25, 2019 5:53 AM
> To: Qiming Yang <qiming.yang at intel.com>; Wenzhuo Lu 
> <wenzhuo.lu at intel.com>
> Cc: dev at dpdk.org; Qi Zhang <qi.z.zhang at intel.com>; Xiaolong Ye 
> <xiaolong.ye at intel.com>; Beilei Xing <beilei.xing at intel.com>; Yahui 
> Cao <yahui.cao at intel.com>
> Subject: [dpdk-dev] [PATCH v3 1/8] net/ice: enable flow director 
> engine
> 
> From: Beilei Xing <beilei.xing at intel.com>
> 
> Enable flow director engine, including initialization and teardown.
>  - Control VSI create and release.
>  - Queue pair allocated, set up and release.
>  - Programming packet create and release.
>  - FDIR profile create and release.
> 
> Signed-off-by: Beilei Xing <beilei.xing at intel.com>
> ---



More information about the dev mailing list