[dpdk-dev] [PATCH v4 1/5] net/e1000: release port upon close

Di, ChenxuX chenxux.di at intel.com
Thu Sep 26 05:21:59 CEST 2019



> -----Original Message-----
> From: Ye, Xiaolong
> Sent: Wednesday, September 25, 2019 11:41 PM
> To: Di, ChenxuX <chenxux.di at intel.com>
> Cc: dev at dpdk.org; Yang, Qiming <qiming.yang at intel.com>
> Subject: Re: [dpdk-dev] [PATCH v4 1/5] net/e1000: release port upon close
> 
> On 09/19, Di ChenxuX wrote:
> >Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources
> >for the port can be freed by rte_eth_dev_close().
> >
> >Signed-off-by: Di ChenxuX <chenxux.di at intel.com>
> >---
> > doc/guides/rel_notes/release_19_11.rst |   5 +
> > drivers/net/e1000/igb_ethdev.c         | 144 ++++++++++++-------------
> 
> As I commented before, you also need to do the migration for the em_ethdev.c.

Ok , I will do it in the next version of patch.

> 
> > 2 files changed, 77 insertions(+), 72 deletions(-)
> >
> >diff --git a/doc/guides/rel_notes/release_19_11.rst
> >b/doc/guides/rel_notes/release_19_11.rst
> >index 27cfbd9e3..334756906 100644
> >--- a/doc/guides/rel_notes/release_19_11.rst
> >+++ b/doc/guides/rel_notes/release_19_11.rst
> >@@ -56,6 +56,11 @@ New Features
> >      Also, make sure to start the actual text at the margin.
> >      =========================================================
> >
> >+* **Updated the Intel drivers.**
> >+
> >+  * Added support for the ``RTE_ETH_DEV_CLOSE_REMOVE`` flag for
> >+    e1000, fm10k, i40e, ice, ixgbe.
> >+
> 
> I think it makes more scene to separate release notes in respective patches, as
> this patch just update e1000 pmd.
> 

OK. I will do it in the next version of patch.

> >
> > Removed Items
> > -------------
> >diff --git a/drivers/net/e1000/igb_ethdev.c
> >b/drivers/net/e1000/igb_ethdev.c index fec2b4289..c610042c3 100644
> >--- a/drivers/net/e1000/igb_ethdev.c
> >+++ b/drivers/net/e1000/igb_ethdev.c
> >@@ -843,6 +843,11 @@ eth_igb_dev_init(struct rte_eth_dev *eth_dev)
> > 	rte_ether_addr_copy((struct rte_ether_addr *)hw->mac.addr,
> > 			&eth_dev->data->mac_addrs[0]);
> >
> 
> [snip]
> 
> > static int
> >@@ -1579,14 +1532,13 @@ static void
> > eth_igb_close(struct rte_eth_dev *dev)  {
> > 	struct e1000_hw *hw = E1000_DEV_PRIVATE_TO_HW(dev->data-
> >dev_private);
> >-	struct e1000_adapter *adapter =
> >-		E1000_DEV_PRIVATE(dev->data->dev_private);
> > 	struct rte_eth_link link;
> > 	struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
> > 	struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
> >+	struct e1000_filter_info *filter_info =
> >+		E1000_DEV_PRIVATE_TO_FILTER_INFO(dev->data-
> >dev_private);
> >
> > 	eth_igb_stop(dev);
> >-	adapter->stopped = 1;
> >
> > 	e1000_phy_hw_reset(hw);
> > 	igb_release_manageability(hw);
> >@@ -1610,6 +1562,40 @@ eth_igb_close(struct rte_eth_dev *dev)
> >
> > 	memset(&link, 0, sizeof(link));
> > 	rte_eth_linkstatus_set(dev, &link);
> >+
> >+	dev->dev_ops = NULL;
> >+	dev->rx_pkt_burst = NULL;
> >+	dev->tx_pkt_burst = NULL;
> >+
> >+	/* Reset any pending lock */
> >+	igb_reset_swfw_lock(hw);
> >+
> >+	/* uninitialize PF if max_vfs not zero */
> >+	igb_pf_host_uninit(dev);
> >+
> >+	rte_intr_callback_unregister(intr_handle,
> >+				     eth_igb_interrupt_handler, dev);
> 
> why rte_intr_disable(intr_handle) is missing here?
> 

rte_intr_disable(intr_handle) has been called in eth_igb_stop(dev). So I delete it to prevent the repeat.

> >+

[snip]
 
> Ditto.
> 
> Thanks,
> Xiaolong
> 
> > }
> >
> > static void
> >--
> >2.17.1
> >


More information about the dev mailing list