[dpdk-dev] [PATCH v3 1/2] ethdev: extend RSS offload types

[Andrew Rybchenko]

On 9/25/19 5:06 PM, Simei Su wrote:
> This patch cover two aspects:
>    (1)decouple RTE_ETH_FLOW_* and ETH_RSS_*. Because both serve
>       different purposes.
>    (2)reserve several bits as input set selection from the high
>       end of the 64 bits. It is combined with exisiting ETH_RSS_*
>       to represent rss types.

If the patch covers two aspects why it is one patch instead of two?
It would be useful to motivate decouple a bit getter and provide
details since "different purposes" are hardly very useful. Which
purposes?

>    for example:
>       ETH_RSS_IPV4 | ETH_RSS_L3_SRC_ONLY: hash on src ip address only

Is  (ETH_RSS_IPV4 | ETH_RSS_L3_SRC_ONLY | ETH_RSS_L3_DST_ONLY)
valid and an equivalent to ETH_RSS_IPV4 only?
If yes, shouldn't generic API care about it or each driver should do it?
Similar question is applicable to L4.

>       ETH_RSS_IPV4_UDP | ETH_RSS_L4_DST_ONLY: hash on src/dst IP and
>                                               dst UDP port
>       ETH_RSS_L2_PAYLOAD | ETH_RSS_L2_DST_ONLY: hash on dst mac address

I'm a bit confused by L2_PAYLOAD | L2_DST_ONLY. Does L2_PAYLOAD
mean entire L2 frame including header and payload?

> Signed-off-by: Simei Su <simei.su at intel.com>

[snip]