[dpdk-dev] [PATCH v1 1/4] ethdev: add the API for getting burst mode information

[Wang, Haiyue]

> -----Original Message-----
> From: Ye, Xiaolong
> Sent: Thursday, September 26, 2019 21:41
> To: Wang, Haiyue <haiyue.wang at intel.com>
> Cc: dev at dpdk.org; Yigit, Ferruh <ferruh.yigit at intel.com>; Kinsella, Ray <ray.kinsella at intel.com>;
> Iremonger, Bernard <bernard.iremonger at intel.com>; Sun, Chenmin <chenmin.sun at intel.com>
> Subject: Re: [PATCH v1 1/4] ethdev: add the API for getting burst mode information
> 
> On 09/26, Haiyue Wang wrote:
> >Some PMDs have more than one RX/TX burst paths, add the ethdev API
> >that allows an application to retrieve the mode information about
> >Rx/Tx packet burst such as Scalar or Vector, and Vector technology
> >like AVX2.
> >
> >Signed-off-by: Haiyue Wang <haiyue.wang at intel.com>
> >Acked-by: Bernard Iremonger <bernard.iremonger at intel.com>
> >---
> > doc/guides/rel_notes/release_19_11.rst   |  9 +++
> > lib/librte_ethdev/rte_ethdev.c           | 75 ++++++++++++++++++++++
> > lib/librte_ethdev/rte_ethdev.h           | 82 ++++++++++++++++++++++++
> > lib/librte_ethdev/rte_ethdev_core.h      |  5 ++
> > lib/librte_ethdev/rte_ethdev_version.map |  5 ++
> > 5 files changed, 176 insertions(+)
> >
> 
> [snip]
> 
> >+typedef void (*eth_burst_mode_get_t)(struct rte_eth_dev *dev,
> >+	uint16_t queue_id, struct rte_eth_burst_mode *mode);
> >+
> 
> There is ongoing effort to change the return type of dev_ops callback from
> void to int, like [1]
> 
> Better to keep align with it.
> 
> [1] http://patchwork.dpdk.org/project/dpdk/list/?series=6391
> 

OK, will update on v2.

> Thanks,
> Xiaolong
> 
> > typedef int (*mtu_set_t)(struct rte_eth_dev *dev, uint16_t mtu);
> > /**< @internal Set MTU. */
> >
> >@@ -542,6 +545,8 @@ struct eth_dev_ops {
> > 	eth_dev_infos_get_t        dev_infos_get; /**< Get device info. */
> > 	eth_rxq_info_get_t         rxq_info_get; /**< retrieve RX queue information. */
> > 	eth_txq_info_get_t         txq_info_get; /**< retrieve TX queue information. */
> >+	eth_burst_mode_get_t       rx_burst_mode_get; /**< Get RX burst mode */
> >+	eth_burst_mode_get_t       tx_burst_mode_get; /**< Get TX burst mode */
> > 	eth_fw_version_get_t       fw_version_get; /**< Get firmware version. */
> > 	eth_dev_supported_ptypes_get_t dev_supported_ptypes_get;
> > 	/**< Get packet types supported and identified by device. */
> >diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev/rte_ethdev_version.map
> >index 6df42a47b..e59d51648 100644
> >--- a/lib/librte_ethdev/rte_ethdev_version.map
> >+++ b/lib/librte_ethdev/rte_ethdev_version.map
> >@@ -283,4 +283,9 @@ EXPERIMENTAL {
> >
> > 	# added in 19.08
> > 	rte_eth_read_clock;
> >+
> >+	# added in 19.11
> >+	rte_eth_rx_burst_mode_get;
> >+	rte_eth_tx_burst_mode_get;
> >+	rte_eth_burst_mode_option_name;
> > };
> >--
> >2.17.1
> >