[dpdk-dev] [PATCH v5 2/4] power: extend guest channel API for reading

[Daly, Lee]

> On 05/04/2019 14:24, Hajkowski wrote:
> > From: Marcin Hajkowski <marcinx.hajkowski at intel.com>
> >
> > Added new experimental API rte_power_guest_channel_receive_msg
> > which gives possibility to receive messages send to guest.
> >
> > Signed-off-by: Marcin Hajkowski <marcinx.hajkowski at intel.com>
> > ---
> >   lib/librte_power/channel_commands.h    |  5 +++
> >   lib/librte_power/guest_channel.c       | 60 ++++++++++++++++++++++++++
> >   lib/librte_power/guest_channel.h       | 35 +++++++++++++++
> >   lib/librte_power/rte_power_version.map |  1 +
> >   4 files changed, 101 insertions(+)
> >
> > diff --git a/lib/librte_power/channel_commands.h
> > b/lib/librte_power/channel_commands.h


<...>

> > diff --git a/lib/librte_power/rte_power_version.map
> > b/lib/librte_power/rte_power_version.map
> > index 042917360..69f5ea3f4 100644
> > --- a/lib/librte_power/rte_power_version.map
> > +++ b/lib/librte_power/rte_power_version.map
> > @@ -44,4 +44,5 @@ EXPERIMENTAL {
> >   	rte_power_empty_poll_stat_update;
> >   	rte_power_poll_stat_fetch;
> >   	rte_power_poll_stat_update;
> > +	rte_power_guest_channel_receive_msg;
> >   };
Nit Pick, new api should be added in alphabetical order, i.e after "rte_power_empty_poll_stat_update" .

> 
> 
> I tested this with the later patches in the set, and the acknowledges
> successfully get back to the guest from the host in the form of an Ack or Nack
> for various commands sent from the guest.
> 
> Tested-by: David Hunt <david.hunt at intel.com>
> 

Feel free to add my ack after the above minor change. 
Acked-by: Lee Daly <lee.daly at intel.com>