[dpdk-dev] [PATCH] net/ena: change license clause to SPDX tags

Ferruh Yigit ferruh.yigit at intel.com
Fri Sep 27 10:34:56 CEST 2019


On 9/27/2019 6:32 AM, Hemant Agrawal wrote:
> 
>> -----Original Message-----
>> From: dev <dev-bounces at dpdk.org> On Behalf Of Ferruh Yigit
>> Sent: Thursday, September 26, 2019 11:17 PM
>> To: Maciej Bielski <mba at semihalf.com>; dev at dpdk.org
>> Cc: Marcin Wojtas <mw at semihalf.com>; Michal Krawczyk
>> <mk at semihalf.com>; Guy Tzalik <gtzalik at amazon.com>; Evgeny Schemeilin
>> <evgenys at amazon.com>
>> Subject: Re: [dpdk-dev] [PATCH] net/ena: change license clause to SPDX tags
>>
>> On 9/26/2019 1:31 PM, Maciej Bielski wrote:
>>> Signed-off-by: Maciej Bielski <mba at semihalf.com>
>>> Acked-by: Michal Krawczyk <mk at semihalf.com>
>>
>> <...>
>>
>>> diff --git a/drivers/net/ena/meson.build b/drivers/net/ena/meson.build
>>> index 091ca6e3f..c7e71f494 100644
>>> --- a/drivers/net/ena/meson.build
>>> +++ b/drivers/net/ena/meson.build
>>> @@ -1,5 +1,6 @@
>>>  # SPDX-License-Identifier: BSD-3-Clause -# Copyright(c) 2018 Intel
>>> Corporation
>>> +# Copyright(c) 2015-2019 Amazon.com, Inc. or its affiliates.
>>> +# All rights reserved.
>>>
>>
>> This part is changing the copyright owner, it is under the ena driver but still is
>> there a reason to change the owner?
>>
>> Overall this is a meson file, I personally don't see the meaning of having a
>> copyright in a meson file, but trying to be fair.
>>
>> Would you mind keeping the original copyright for the file?
> [Hemant] Not sure, if you kept the Intel's copyright by mistake or you copied this file from other driver having Intel's copyright.
> You may like to keep add yours, but not delete the old one. 
> 

Hi Hemant,

It is not because of copy/paste, whole file developed and pushed by Bruce at
first place, there is no other update to the file from any other author:
Commit 952afd9adf0c ("net/ena: add to meson build")


More information about the dev mailing list