[dpdk-dev] [PATCH 07/12] net/cxgbe: use dynamic logging for debug prints

Ferruh Yigit ferruh.yigit at intel.com
Fri Sep 27 16:37:20 CEST 2019


On 9/6/2019 10:52 PM, Rahul Lakkireddy wrote:
> Remove compile time flags and use dynamic logging for debug prints.
> 
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy at chelsio.com>
> ---
>  config/common_base               |  5 ---
>  doc/guides/nics/cxgbe.rst        | 20 -----------
>  drivers/net/cxgbe/cxgbe_compat.h | 58 +++++++++++---------------------
>  drivers/net/cxgbe/cxgbe_ethdev.c | 16 +++++++++
>  4 files changed, 35 insertions(+), 64 deletions(-)
> 
> diff --git a/config/common_base b/config/common_base
> index 8ef75c203..43964de6d 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -217,11 +217,6 @@ CONFIG_RTE_LIBRTE_BNXT_PMD=y
>  # Compile burst-oriented Chelsio Terminator (CXGBE) PMD
>  #
>  CONFIG_RTE_LIBRTE_CXGBE_PMD=y
> -CONFIG_RTE_LIBRTE_CXGBE_DEBUG=n

+1, thanks.

> -CONFIG_RTE_LIBRTE_CXGBE_DEBUG_REG=n
> -CONFIG_RTE_LIBRTE_CXGBE_DEBUG_MBOX=n

Are above two used on datapath?

> -CONFIG_RTE_LIBRTE_CXGBE_DEBUG_TX=n
> -CONFIG_RTE_LIBRTE_CXGBE_DEBUG_RX=n

Are you sure about these?
If these logs are enabled in datapath, switching to the dynamic log will add
additional checks for logging, most probably per packet.


More information about the dev mailing list